Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1713463002: Make RemoteBitrateEstimator::GetStats() virtual. (Closed)

Created:
4 years, 10 months ago by stefan-webrtc
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make RemoteBitrateEstimator::GetStats() virtual. Should have been added in https://chromium.googlesource.com/external/webrtc/+/59c634b605a906d292179bc5568469c030b9e9d0. R=kjellander@webrtc.org Committed: https://crrev.com/3ee73a59adf883bec3bb946c39b7d8e44154f8e9 Cr-Commit-Position: refs/heads/master@{#11667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
stefan-webrtc
4 years, 10 months ago (2016-02-18 10:29:21 UTC) #2
kjellander_webrtc
lgtm
4 years, 10 months ago (2016-02-18 10:32:35 UTC) #3
stefan-webrtc
Committed patchset #1 (id:1) manually as 3ee73a59adf883bec3bb946c39b7d8e44154f8e9 (presubmit successful).
4 years, 10 months ago (2016-02-18 10:42:45 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 10:42:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ee73a59adf883bec3bb946c39b7d8e44154f8e9
Cr-Commit-Position: refs/heads/master@{#11667}

Powered by Google App Engine
This is Rietveld 408576698