webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h - Issue 1713463002: Make RemoteBitrateEstimator::GetStats() virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

Issue 1713463002: Make RemoteBitrateEstimator::GetStats() virtual. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

diff --git a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

index 21865308aa08b884ce9b2d3dce9083c98bdfb892..e56c273fc4ba5e2808abbb3642b419a4c050e299 100644

--- a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

+++ b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

@@ -71,7 +71,7 @@ class RemoteBitrateEstimator : public CallStatsObserver, public Module {

uint32_t* bitrate_bps) const = 0;

// TODO(holmer): Remove when all implementations have been updated.

- bool GetStats(ReceiveBandwidthEstimatorStats* output) const {

+ virtual bool GetStats(ReceiveBandwidthEstimatorStats* output) const {

return false;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »