Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1710483002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/ BUG=webrtc:5520 Committed: https://crrev.com/88788adcfd9e84e3e8882806e68d759898be0907 Cr-Commit-Position: refs/heads/master@{#11684}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -95 lines) Patch
M webrtc/modules/audio_processing/agc/agc.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_manager_direct.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/agc/histogram.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/histogram_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.h View 2 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 6 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/complex_matrix.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/matrix.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 2 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_utils.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/level_estimator_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/agc/activity_metric.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kwiberg-webrtc
kjellander: webrtc/tools peah: everything
4 years, 10 months ago (2016-02-17 19:16:39 UTC) #2
kjellander_webrtc
webrtc/tools: lgtm
4 years, 10 months ago (2016-02-17 19:29:01 UTC) #3
peah-webrtc
On 2016/02/17 19:29:01, kjellander (webrtc) wrote: > webrtc/tools: lgtm lgtm
4 years, 10 months ago (2016-02-19 10:37:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710483002/1
4 years, 10 months ago (2016-02-19 12:51:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_dbg/builds/192) android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-19 12:53:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710483002/20001
4 years, 10 months ago (2016-02-19 14:07:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 15:04:53 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:05:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88788adcfd9e84e3e8882806e68d759898be0907
Cr-Commit-Position: refs/heads/master@{#11684}

Powered by Google App Engine
This is Rietveld 408576698