Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: webrtc/modules/audio_processing/echo_cancellation_impl_unittest.cc

Issue 1710483002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <memory>
12
11 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
12 #include "webrtc/base/scoped_ptr.h"
13 extern "C" { 14 extern "C" {
14 #include "webrtc/modules/audio_processing/aec/aec_core.h" 15 #include "webrtc/modules/audio_processing/aec/aec_core.h"
15 } 16 }
16 #include "webrtc/modules/audio_processing/include/audio_processing.h" 17 #include "webrtc/modules/audio_processing/include/audio_processing.h"
17 18
18 namespace webrtc { 19 namespace webrtc {
19 20
20 TEST(EchoCancellationInternalTest, ExtendedFilter) { 21 TEST(EchoCancellationInternalTest, ExtendedFilter) {
21 rtc::scoped_ptr<AudioProcessing> ap(AudioProcessing::Create()); 22 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create());
22 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL); 23 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL);
23 24
24 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true)); 25 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true));
25 EXPECT_TRUE(ap->echo_cancellation()->is_enabled()); 26 EXPECT_TRUE(ap->echo_cancellation()->is_enabled());
26 27
27 AecCore* aec_core = ap->echo_cancellation()->aec_core(); 28 AecCore* aec_core = ap->echo_cancellation()->aec_core();
28 ASSERT_TRUE(aec_core != NULL); 29 ASSERT_TRUE(aec_core != NULL);
29 // Disabled by default. 30 // Disabled by default.
30 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 31 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
31 32
32 Config config; 33 Config config;
33 config.Set<ExtendedFilter>(new ExtendedFilter(true)); 34 config.Set<ExtendedFilter>(new ExtendedFilter(true));
34 ap->SetExtraOptions(config); 35 ap->SetExtraOptions(config);
35 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core)); 36 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core));
36 37
37 // Retains setting after initialization. 38 // Retains setting after initialization.
38 EXPECT_EQ(ap->kNoError, ap->Initialize()); 39 EXPECT_EQ(ap->kNoError, ap->Initialize());
39 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core)); 40 EXPECT_EQ(1, WebRtcAec_extended_filter_enabled(aec_core));
40 41
41 config.Set<ExtendedFilter>(new ExtendedFilter(false)); 42 config.Set<ExtendedFilter>(new ExtendedFilter(false));
42 ap->SetExtraOptions(config); 43 ap->SetExtraOptions(config);
43 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 44 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
44 45
45 // Retains setting after initialization. 46 // Retains setting after initialization.
46 EXPECT_EQ(ap->kNoError, ap->Initialize()); 47 EXPECT_EQ(ap->kNoError, ap->Initialize());
47 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 48 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
48 } 49 }
49 50
50 TEST(EchoCancellationInternalTest, DelayAgnostic) { 51 TEST(EchoCancellationInternalTest, DelayAgnostic) {
51 rtc::scoped_ptr<AudioProcessing> ap(AudioProcessing::Create()); 52 std::unique_ptr<AudioProcessing> ap(AudioProcessing::Create());
52 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL); 53 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL);
53 54
54 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true)); 55 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true));
55 EXPECT_TRUE(ap->echo_cancellation()->is_enabled()); 56 EXPECT_TRUE(ap->echo_cancellation()->is_enabled());
56 57
57 AecCore* aec_core = ap->echo_cancellation()->aec_core(); 58 AecCore* aec_core = ap->echo_cancellation()->aec_core();
58 ASSERT_TRUE(aec_core != NULL); 59 ASSERT_TRUE(aec_core != NULL);
59 // Enabled by default. 60 // Enabled by default.
60 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 61 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
61 62
62 Config config; 63 Config config;
63 config.Set<DelayAgnostic>(new DelayAgnostic(true)); 64 config.Set<DelayAgnostic>(new DelayAgnostic(true));
64 ap->SetExtraOptions(config); 65 ap->SetExtraOptions(config);
65 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core)); 66 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
66 67
67 // Retains setting after initialization. 68 // Retains setting after initialization.
68 EXPECT_EQ(ap->kNoError, ap->Initialize()); 69 EXPECT_EQ(ap->kNoError, ap->Initialize());
69 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core)); 70 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
70 71
71 config.Set<DelayAgnostic>(new DelayAgnostic(false)); 72 config.Set<DelayAgnostic>(new DelayAgnostic(false));
72 ap->SetExtraOptions(config); 73 ap->SetExtraOptions(config);
73 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 74 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
74 75
75 // Retains setting after initialization. 76 // Retains setting after initialization.
76 EXPECT_EQ(ap->kNoError, ap->Initialize()); 77 EXPECT_EQ(ap->kNoError, ap->Initialize());
77 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core)); 78 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
78 } 79 }
79 80
80 } // namespace webrtc 81 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.h ('k') | webrtc/modules/audio_processing/echo_control_mobile_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698