Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1710293002: Blacklist "build/c++11" cpplint filter. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Blacklist "build/c++11" cpplint filter. This CL removes "build/c++11" from the cpplint filters. The same was changed in "depot_tools" in https://codereview.chromium.org/1573663003/ From the other CL: ----- The checks are not reliable for Rvalue references, and only are allowing default/deleted constructors. They are based on the google3 internal rules which do not exactly match our own c++11 rules, and may diverge more over time. ----- NOTRY=True Committed: https://crrev.com/c4e3ead352c8b66060c17b354313f1cb1892d74e Cr-Commit-Position: refs/heads/master@{#11678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joachim
Ptal I stumbled upon this while adding a new class that implements a move constructor ...
4 years, 10 months ago (2016-02-19 00:37:52 UTC) #2
kjellander_webrtc
lgtm thanks for spending time on digging this out. I filed https://bugs.chromium.org/p/webrtc/issues/detail?id=5552 to track fixing ...
4 years, 10 months ago (2016-02-19 07:20:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710293002/1
4 years, 10 months ago (2016-02-19 08:23:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:25:59 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:26:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4e3ead352c8b66060c17b354313f1cb1892d74e
Cr-Commit-Position: refs/heads/master@{#11678}

Powered by Google App Engine
This is Rietveld 408576698