Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: PRESUBMIT.py

Issue 1710293002: Blacklist "build/c++11" cpplint filter. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 8ea0f3a86a9c159d2f9c926f5e267bb4ab654ed7..011e3afd2da647e775ffa9a09acaccdfab10c8ac 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -31,6 +31,17 @@ CPPLINT_DIRS = [
'webrtc/video',
]
+# These filters will always be removed, even if the caller specifies a filter
+# set, as they are problematic or broken in some way.
+#
+# Justifications for each filter:
+# - build/c++11 : Rvalue ref checks are unreliable (false positives),
+# include file and feature blacklists are
+# google3-specific.
+BLACKLIST_LINT_FILTERS = [
+ '-build/c++11',
+]
+
# List of directories of "supported" native APIs. That means changes to headers
# will be done in a compatible way following this scheme:
# 1. Non-breaking changes are made.
@@ -172,6 +183,10 @@ def _CheckApprovedFilesLintClean(input_api, output_api,
# pylint: disable=W0212
cpplint._cpplint_state.ResetErrorCounts()
+ lint_filters = cpplint._Filters()
+ lint_filters.extend(BLACKLIST_LINT_FILTERS)
+ cpplint._SetFilters(','.join(lint_filters))
+
# Create a platform independent whitelist for the CPPLINT_DIRS.
whitelist_dirs = [input_api.os_path.join(*path.split('/'))
for path in CPPLINT_DIRS]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698