Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 1710083006: Changes in the wav_file implementation in order to avoid clang warnings (Closed)

Created:
4 years, 10 months ago by peah-webrtc
Modified:
4 years, 10 months ago
Reviewers:
the sun, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changes in the wav_file implementation in order to avoid clang warnings. The changes does not change any of the functionality in the code. BUG=webrtc:163 Committed: https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3 Cr-Commit-Position: refs/heads/master@{#11705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M webrtc/common_audio/wav_file.h View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
peah-webrtc
4 years, 10 months ago (2016-02-19 11:54:12 UTC) #2
the sun
lgtm except for the issue title; this CL does NOT change any functionality, it just ...
4 years, 10 months ago (2016-02-19 11:57:17 UTC) #3
peah-webrtc
On 2016/02/19 11:57:17, the sun wrote: > lgtm except for the issue title; this CL ...
4 years, 10 months ago (2016-02-19 11:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083006/1
4 years, 10 months ago (2016-02-19 12:00:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3547)
4 years, 10 months ago (2016-02-19 12:10:25 UTC) #9
peah-webrtc
Adding Henrik as being one of the OWNERS of the file.
4 years, 10 months ago (2016-02-19 12:16:21 UTC) #11
hlundin-webrtc
lgtm
4 years, 10 months ago (2016-02-22 09:13:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083006/1
4 years, 10 months ago (2016-02-22 09:14:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 10:13:33 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 10:13:40 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1f718bb1ead2d0287bdb75ff8772ac74636b2d3
Cr-Commit-Position: refs/heads/master@{#11705}

Powered by Google App Engine
This is Rietveld 408576698