Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: webrtc/common_audio/wav_file.h

Issue 1710083006: Changes in the wav_file implementation in order to avoid clang warnings (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/common_audio/wav_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_audio/wav_file.h
diff --git a/webrtc/common_audio/wav_file.h b/webrtc/common_audio/wav_file.h
index e656eb8643e5af18ccaaca48bd215021e99ff6bc..812c21dafae6688760261b9b03981ff8839a0183 100644
--- a/webrtc/common_audio/wav_file.h
+++ b/webrtc/common_audio/wav_file.h
@@ -42,7 +42,7 @@ class WavWriter final : public WavFile {
WavWriter(const std::string& filename, int sample_rate, size_t num_channels);
// Close the WAV file, after writing its header.
- ~WavWriter();
+ ~WavWriter() override;
// Write additional samples to the file. Each sample is in the range
// [-32768,32767], and there must be the previously specified number of
@@ -50,9 +50,9 @@ class WavWriter final : public WavFile {
void WriteSamples(const float* samples, size_t num_samples);
void WriteSamples(const int16_t* samples, size_t num_samples);
- int sample_rate() const override { return sample_rate_; }
- size_t num_channels() const override { return num_channels_; }
- size_t num_samples() const override { return num_samples_; }
+ int sample_rate() const override;
+ size_t num_channels() const override;
+ size_t num_samples() const override;
private:
void Close();
@@ -71,16 +71,16 @@ class WavReader final : public WavFile {
explicit WavReader(const std::string& filename);
// Close the WAV file.
- ~WavReader();
+ ~WavReader() override;
// Returns the number of samples read. If this is less than requested,
// verifies that the end of the file was reached.
size_t ReadSamples(size_t num_samples, float* samples);
size_t ReadSamples(size_t num_samples, int16_t* samples);
- int sample_rate() const override { return sample_rate_; }
- size_t num_channels() const override { return num_channels_; }
- size_t num_samples() const override { return num_samples_; }
+ int sample_rate() const override;
+ size_t num_channels() const override;
+ size_t num_samples() const override;
private:
void Close();
« no previous file with comments | « no previous file | webrtc/common_audio/wav_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698