Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1704463002: Fix out-of-buffer write in iLBC (Closed)

Created:
4 years, 10 months ago by hlundin-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ilbc-fuzz-fix568889
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix out-of-buffer write in iLBC In some cases, the decoder can write outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568885, webrtc:5305 Committed: https://crrev.com/2c38c20e7bce3e4fe41dfdab3db0582cea39de20 Cr-Commit-Position: refs/heads/master@{#11641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M webrtc/modules/audio_coding/codecs/ilbc/create_augmented_vec.c View 1 chunk +17 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Tina, please, take a look. Thanks!
4 years, 10 months ago (2016-02-16 13:47:24 UTC) #2
tlegrand-webrtc
On 2016/02/16 13:47:24, hlundin-webrtc wrote: > Tina, please, take a look. > > Thanks! Nice! ...
4 years, 10 months ago (2016-02-16 14:52:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704463002/1
4 years, 10 months ago (2016-02-16 16:44:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 18:01:54 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:02:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c38c20e7bce3e4fe41dfdab3db0582cea39de20
Cr-Commit-Position: refs/heads/master@{#11641}

Powered by Google App Engine
This is Rietveld 408576698