Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1700973002:
Fix out-of-buffer read in iLBC (Closed)
|
Created:
4 years, 10 months ago by hlundin-webrtc Modified:
4 years, 10 months ago Reviewers:
tlegrand-webrtc CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix out-of-buffer read in iLBC
In some cases, the decoder can read outside of an allocated array. See
the new comment in the code for more details.
BUG=chromium:568889, webrtc:5305
Committed: https://crrev.com/ee31f0a7d5ed564cd12704e000b9ccabf9266f03
Cr-Commit-Position: refs/heads/master@{#11637}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 18 (9 generated)
Description was changed from ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chrome:568889, webrtc:5305 ========== to ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568889, webrtc:5305 ==========
The CQ bit was checked by henrik.lundin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700973002/1
henrik.lundin@webrtc.org changed reviewers: + tina.legrand@webrtc.org
Tina, please, take a look. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9872)
On 2016/02/16 13:52:29, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > linux_tsan2 on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9872) lgtm
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700973002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700973002/1
Message was sent while issue was closed.
Description was changed from ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568889, webrtc:5305 ========== to ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568889, webrtc:5305 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568889, webrtc:5305 ========== to ========== Fix out-of-buffer read in iLBC In some cases, the decoder can read outside of an allocated array. See the new comment in the code for more details. BUG=chromium:568889, webrtc:5305 Committed: https://crrev.com/ee31f0a7d5ed564cd12704e000b9ccabf9266f03 Cr-Commit-Position: refs/heads/master@{#11637} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ee31f0a7d5ed564cd12704e000b9ccabf9266f03 Cr-Commit-Position: refs/heads/master@{#11637} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
