Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1703833002: Remove ignored return code from modules. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ignored return code from modules. ModuleProcessImpl doesn't act on return codes and having them around is confusing (it's unclear what an error return code here would do even). BUG= R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/f14c47a58cb2a333cb9b11aef593f0e632fdb28a

Patch Set 1 #

Patch Set 2 : remove nuke comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -192 lines) Patch
M webrtc/api/test/fakeaudiocapturemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideocapturemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/include/audio_conference_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_device/include/fake_audio_device.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/include/module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 1 2 8 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 7 chunks +13 lines, -14 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/video_render/video_render.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/modules/video_render/video_render_internal_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/video/call_stats.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/call_stats.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/video/vie_sync_module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_sync_module.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M webrtc/voice_engine/monitor_module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/monitor_module.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
pbos-webrtc
PTAL, yay.
4 years, 10 months ago (2016-02-17 11:13:25 UTC) #1
pbos-webrtc
remove nuke comment
4 years, 10 months ago (2016-02-17 11:58:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703833002/20001
4 years, 10 months ago (2016-02-17 11:59:49 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/5568)
4 years, 10 months ago (2016-02-17 15:07:31 UTC) #6
tommi
lgtm Thanks!
4 years, 10 months ago (2016-02-18 19:04:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703833002/20001
4 years, 10 months ago (2016-02-18 19:04:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/9934) linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 19:07:02 UTC) #11
pbos-webrtc
rebase
4 years, 10 months ago (2016-02-24 15:50:17 UTC) #12
pbos-webrtc
Committed patchset #3 (id:40001) manually as f14c47a58cb2a333cb9b11aef593f0e632fdb28a (presubmit successful).
4 years, 10 months ago (2016-02-24 15:51:30 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f14c47a58cb2a333cb9b11aef593f0e632fdb28a Cr-Commit-Position: refs/heads/master@{#11747}
4 years, 10 months ago (2016-02-24 15:51:32 UTC) #16
torbjorng (webrtc)
4 years, 10 months ago (2016-02-25 12:33:32 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1736663004/ by torbjorng@webrtc.org.

The reason for reverting is: Breaks Chromium..

Powered by Google App Engine
This is Rietveld 408576698