Remove ignored return code from modules.

webrtc/modules/utility/source/process_thread_impl_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 10 matching lines @@
 using ::testing::_;
 using ::testing::DoAll;
 using ::testing::InSequence;
 using ::testing::Invoke;
 using ::testing::Return;
 using ::testing::SetArgPointee;
 
 class MockModule : public Module {
  public:
   MOCK_METHOD0(TimeUntilNextProcess, int64_t());
-  MOCK_METHOD0(Process, int32_t());
+  MOCK_METHOD0(Process, void());
   MOCK_METHOD1(ProcessThreadAttached, void(ProcessThread*));
 };
 
 class RaiseEventTask : public ProcessTask {
  public:
   RaiseEventTask(EventWrapper* event) : event_(event) {}
   void Run() override { event_->Set(); }
 
  private:
   EventWrapper* event_;
@@ skipping 28 matching lines @@
 // Verifies that we get at least call back to Process() on the worker thread.
 TEST(ProcessThreadImpl, ProcessCall) {
   ProcessThreadImpl thread("ProcessThread");
   thread.Start();
 
   rtc::scoped_ptr<EventWrapper> event(EventWrapper::Create());
 
   MockModule module;
   EXPECT_CALL(module, TimeUntilNextProcess()).WillRepeatedly(Return(0));
   EXPECT_CALL(module, Process())
-      .WillOnce(DoAll(SetEvent(event.get()), Return(0)))
-      .WillRepeatedly(Return(0));
+      .WillOnce(DoAll(SetEvent(event.get()), Return()))
+      .WillRepeatedly(Return());
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
 
   thread.RegisterModule(&module);
   EXPECT_EQ(kEventSignaled, event->Wait(100));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.Stop();
 }
 
 // Same as ProcessCall except the module is registered before the
 // call to Start().
 TEST(ProcessThreadImpl, ProcessCall2) {
   ProcessThreadImpl thread("ProcessThread");
   rtc::scoped_ptr<EventWrapper> event(EventWrapper::Create());
 
   MockModule module;
   EXPECT_CALL(module, TimeUntilNextProcess()).WillRepeatedly(Return(0));
   EXPECT_CALL(module, Process())
-      .WillOnce(DoAll(SetEvent(event.get()), Return(0)))
-      .WillRepeatedly(Return(0));
+      .WillOnce(DoAll(SetEvent(event.get()), Return()))
+      .WillRepeatedly(Return());
 
   thread.RegisterModule(&module);
 
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
   thread.Start();
   EXPECT_EQ(kEventSignaled, event->Wait(100));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.Stop();
 }
 
 // Tests setting up a module for callbacks and then unregister that module.
 // After unregistration, we should not receive any further callbacks.
 TEST(ProcessThreadImpl, Deregister) {
   ProcessThreadImpl thread("ProcessThread");
   rtc::scoped_ptr<EventWrapper> event(EventWrapper::Create());
 
   int process_count = 0;
   MockModule module;
   EXPECT_CALL(module, TimeUntilNextProcess()).WillRepeatedly(Return(0));
   EXPECT_CALL(module, Process())
       .WillOnce(DoAll(SetEvent(event.get()),
                       Increment(&process_count),
-                      Return(0)))
-      .WillRepeatedly(DoAll(Increment(&process_count), Return(0)));
+                      Return()))
+      .WillRepeatedly(DoAll(Increment(&process_count), Return()));
 
   thread.RegisterModule(&module);
 
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
   thread.Start();
 
   EXPECT_EQ(kEventSignaled, event->Wait(100));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.DeRegisterModule(&module);
@@ skipping 19 matching lines @@
   MockModule module;
   int64_t start_time = 0;
   int64_t called_time = 0;
   EXPECT_CALL(module, TimeUntilNextProcess())
       .WillOnce(DoAll(SetTimestamp(&start_time),
                       Return(milliseconds)))
       .WillRepeatedly(Return(milliseconds));
   EXPECT_CALL(module, Process())
       .WillOnce(DoAll(SetTimestamp(&called_time),
                       SetEvent(event.get()),
-                      Return(0)))
-      .WillRepeatedly(Return(0));
+                      Return()))
+      .WillRepeatedly(Return());
 
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
   thread.RegisterModule(&module);
 
   // Add a buffer of 50ms due to slowness of some trybots
   // (e.g. win_drmemory_light)
   EXPECT_EQ(kEventSignaled, event->Wait(milliseconds + 50));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.Stop();
@@ skipping 40 matching lines @@
 
   rtc::scoped_ptr<EventWrapper> event(EventWrapper::Create());
 
   MockModule module;
   int callback_count = 0;
   // Ask for a callback after 20ms.
   EXPECT_CALL(module, TimeUntilNextProcess())
       .WillRepeatedly(Return(20));
   EXPECT_CALL(module, Process())
       .WillRepeatedly(DoAll(Increment(&callback_count),
-                            Return(0)));
+                            Return()));
 
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
   thread.RegisterModule(&module);
 
   EXPECT_EQ(kEventTimeout, event->Wait(1000));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.Stop();
 
   printf("Callback count: %i\n", callback_count);
@@ skipping 23 matching lines @@
   // Then we  wake the thread and there should not be another call made to
   // TimeUntilNextProcess before Process() is called.
   // The second time TimeUntilNextProcess is then called, is after Process
   // has been called and we don't expect any more calls.
   EXPECT_CALL(module, TimeUntilNextProcess())
       .WillOnce(DoAll(SetTimestamp(&start_time),
                       SetEvent(started.get()),
                       Return(1000)))
       .WillOnce(Return(1000));
   EXPECT_CALL(module, Process())
-      .WillOnce(DoAll(SetTimestamp(&called_time),
-                      SetEvent(called.get()),
-                      Return(0)))
-      .WillRepeatedly(Return(0));
+      .WillOnce(
+          DoAll(SetTimestamp(&called_time), SetEvent(called.get()), Return()))
+      .WillRepeatedly(Return());
 
   EXPECT_CALL(module, ProcessThreadAttached(&thread)).Times(1);
   thread.RegisterModule(&module);
 
   EXPECT_EQ(kEventSignaled, started->Wait(100));
   thread.WakeUp(&module);
   EXPECT_EQ(kEventSignaled, called->Wait(100));
 
   EXPECT_CALL(module, ProcessThreadAttached(nullptr)).Times(1);
   thread.Stop();
@@ skipping 10 matching lines @@
   ProcessThreadImpl thread("ProcessThread");
   rtc::scoped_ptr<EventWrapper> task_ran(EventWrapper::Create());
   rtc::scoped_ptr<RaiseEventTask> task(new RaiseEventTask(task_ran.get()));
   thread.Start();
   thread.PostTask(std::move(task));
   EXPECT_EQ(kEventSignaled, task_ran->Wait(100));
   thread.Stop();
 }
 
 }  // namespace webrtc