Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1702943002: Pass ownership of external encoders to the ACM (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Pass ownership of external encoders to the ACM We want this because otherwise the ACM uses its mutex to protect an encoder that's owned by someone else. That someone else may easily slip up and delete or otherwise touch the encoder before making sure that the ACM has stopped using it, bypassing the lock. BUG=webrtc:5028 Committed: https://crrev.com/6030a129c03fdeb0f47e59ca72f14df856ba7ff9 Cr-Commit-Position: refs/heads/master@{#11909}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -244 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 8 chunks +96 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager_unittest.cc View 1 chunk +10 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.h View 2 chunks +7 lines, -8 lines 2 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 5 chunks +22 lines, -27 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc View 3 chunks +57 lines, -47 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 17 chunks +133 lines, -91 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 3 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 12 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-08 10:25:11 UTC) #14
hlundin-webrtc
Very nice! LGTM. https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_coding/acm2/rent_a_codec.h File webrtc/modules/audio_coding/acm2/rent_a_codec.h (right): https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_coding/acm2/rent_a_codec.h#newcode201 webrtc/modules/audio_coding/acm2/rent_a_codec.h:201: std::unique_ptr<AudioEncoder> RentEncoder(const CodecInst& codec_inst); The name ...
4 years, 9 months ago (2016-03-08 13:29:24 UTC) #15
kwiberg-webrtc
https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_coding/acm2/rent_a_codec.h File webrtc/modules/audio_coding/acm2/rent_a_codec.h (right): https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_coding/acm2/rent_a_codec.h#newcode201 webrtc/modules/audio_coding/acm2/rent_a_codec.h:201: std::unique_ptr<AudioEncoder> RentEncoder(const CodecInst& codec_inst); On 2016/03/08 13:29:24, hlundin-webrtc wrote: ...
4 years, 9 months ago (2016-03-08 13:59:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702943002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702943002/240001
4 years, 9 months ago (2016-03-08 13:59:54 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:240001)
4 years, 9 months ago (2016-03-08 14:01:36 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 14:01:45 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6030a129c03fdeb0f47e59ca72f14df856ba7ff9
Cr-Commit-Position: refs/heads/master@{#11909}

Powered by Google App Engine
This is Rietveld 408576698