Pass ownership of external encoders to the ACM

Pass ownership of external encoders to the ACM

We want this because otherwise the ACM uses its mutex to protect an
encoder that's owned by someone else. That someone else may easily
slip up and delete or otherwise touch the encoder before making sure
that the ACM has stopped using it, bypassing the lock.

BUG=webrtc:5028
Committed: https://crrev.com/6030a129c03fdeb0f47e59ca72f14df856ba7ff9
Cr-Commit-Position: refs/heads/master@{#11909}

[kwiberg-webrtc, 2016-03-08 10:03:45]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-03-08 10:04:02]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:04:17]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:04:30]

Patchset #1 (id:60001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:04:47]

Patchset #1 (id:80001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:05:03]

Patchset #1 (id:100001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:05:15]

Patchset #1 (id:120001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:05:32]

Patchset #1 (id:140001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:05:43]

Patchset #1 (id:160001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:05:54]

Patchset #1 (id:180001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:06:15]

Patchset #1 (id:200001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:06:39]

Patchset #1 (id:220001) has been deleted

[kwiberg-webrtc, 2016-03-08 10:25:10]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-03-08 13:29:24]

Very nice! LGTM.

https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/acm2/rent_a_codec.h (right):

https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/acm2/rent_a_codec.h:201:
std::unique_ptr<AudioEncoder> RentEncoder(const CodecInst& codec_inst);
The name RentEncoder is no longer adequate, but I'll accept it anyway.

[kwiberg-webrtc, 2016-03-08 13:59:12]

https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/acm2/rent_a_codec.h (right):

https://codereview.webrtc.org/1702943002/diff/240001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/acm2/rent_a_codec.h:201:
std::unique_ptr<AudioEncoder> RentEncoder(const CodecInst& codec_inst);
On 2016/03/08 13:29:24, hlundin-webrtc wrote:
> The name RentEncoder is no longer adequate, but I'll accept it anyway.

Yeah, the class name isn't a good fit anymore either. But all these names are
going away soon-ish.

[kwiberg-webrtc, 2016-03-08 13:59:42]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-08 13:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702943002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702943002/240001

[commit-bot: I haz the power, 2016-03-08 14:01:36]

Committed patchset #1 (id:240001)

[commit-bot: I haz the power, 2016-03-08 14:01:43]

Description was changed from

==========
Pass ownership of external encoders to the ACM

We want this because otherwise the ACM uses its mutex to protect an
encoder that's owned by someone else. That someone else may easily
slip up and delete or otherwise touch the encoder before making sure
that the ACM has stopped using it, bypassing the lock.

BUG=webrtc:5028
==========

to

==========
Pass ownership of external encoders to the ACM

We want this because otherwise the ACM uses its mutex to protect an
encoder that's owned by someone else. That someone else may easily
slip up and delete or otherwise touch the encoder before making sure
that the ACM has stopped using it, bypassing the lock.

BUG=webrtc:5028

Committed: https://crrev.com/6030a129c03fdeb0f47e59ca72f14df856ba7ff9
Cr-Commit-Position: refs/heads/master@{#11909}
==========

[commit-bot: I haz the power, 2016-03-08 14:01:45]

Patchset 1 (id:??) landed as
https://crrev.com/6030a129c03fdeb0f47e59ca72f14df856ba7ff9
Cr-Commit-Position: refs/heads/master@{#11909}