webrtc/modules/audio_coding/acm2/codec_manager.cc - Issue 1702943002: Pass ownership of external encoders to the ACM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/codec_manager.cc

Issue 1702943002: Pass ownership of external encoders to the ACM (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/acm2/codec_manager.cc

diff --git a/webrtc/modules/audio_coding/acm2/codec_manager.cc b/webrtc/modules/audio_coding/acm2/codec_manager.cc

index ad67377d42daf08a34fd445d3cd8b0deb0145ca7..81adf81a83cf46c9862fce7c371d28edb5085bf0 100644

--- a/webrtc/modules/audio_coding/acm2/codec_manager.cc

+++ b/webrtc/modules/audio_coding/acm2/codec_manager.cc

@@ -113,7 +113,7 @@ bool CodecManager::RegisterEncoder(const CodecInst& send_codec) {

}

send_codec_inst_ = rtc::Optional<CodecInst>(send_codec);

- codec_stack_params_.speech_encoder = nullptr; // Caller must recreate it.

+ codec_stack_params_.speech_encoder.reset(); // Caller must recreate it.

return true;

}