AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to List/vector

AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to List/vector

This CL simplifies the VideoCapturer interface from 'String getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat> getSupportedFormats()'. The intermediate conversion to/from a JSON string is removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector directly instead.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed: https://crrev.com/5199c74d253bf1273a504becb6e3b33571f92a08
Cr-Commit-Position: refs/heads/master@{#11669}

[magjed_webrtc, 2016-02-16 14:00:42]

Description was changed from

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
==========

to

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-02-16 14:00:43]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-02-16 14:00:53]

perkj - Please take a look.

[perkj_webrtc, 2016-02-16 14:35:41]

This might be the last use of json.
please test by removing  from api.gyp:

'conditions': [
            ['build_json==1', {
              'dependencies': [
                '<(DEPTH)/third_party/jsoncpp/jsoncpp.gyp:jsoncpp',
              ],
              'export_dependent_settings': [
                '<(DEPTH)/third_party/jsoncpp/jsoncpp.gyp:jsoncpp',
              ],
            }],

https://codereview.webrtc.org/1702603002/diff/1/webrtc/api/androidvideocaptur...
File webrtc/api/androidvideocapturer.cc (right):

https://codereview.webrtc.org/1702603002/diff/1/webrtc/api/androidvideocaptur...
webrtc/api/androidvideocapturer.cc:123: LOG(LS_INFO) << formats.size() << "
supported formats: ";
is this logged in Java- if so - remove from here.

[magjed_webrtc, 2016-02-18 10:43:36]

https://codereview.webrtc.org/1702603002/diff/1/webrtc/api/androidvideocaptur...
File webrtc/api/androidvideocapturer.cc (right):

https://codereview.webrtc.org/1702603002/diff/1/webrtc/api/androidvideocaptur...
webrtc/api/androidvideocapturer.cc:123: LOG(LS_INFO) << formats.size() << "
supported formats: ";
On 2016/02/16 14:35:41, perkj_webrtc wrote:
> is this logged in Java- if so - remove from here.

Done, but this will be a change from current code.

[perkj_webrtc, 2016-02-18 11:10:00]

lgtm

[magjed_webrtc, 2016-02-18 11:22:53]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-02-18 11:23:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702603002/20001

[commit-bot: I haz the power, 2016-02-18 11:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 11:30:44]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11011)

[magjed_webrtc, 2016-02-18 12:10:06]

Description was changed from

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
==========

to

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5199c74d253bf1273a504becb...
==========

[magjed_webrtc, 2016-02-18 12:10:07]

Committed patchset #2 (id:20001) manually as
5199c74d253bf1273a504becb6e3b33571f92a08 (presubmit successful).

[commit-bot: I haz the power, 2016-02-18 12:10:08]

Description was changed from

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5199c74d253bf1273a504becb...
==========

to

==========
AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to
List/vector

This CL simplifies the VideoCapturer interface from 'String
getSupportedFormatsAsJson() throws JSONException' to 'List<CaptureFormat>
getSupportedFormats()'. The intermediate conversion to/from a JSON string is
removed, and AndroidVideoCapturerJni converts the Java list to a C++ vector
directly instead.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed: https://crrev.com/5199c74d253bf1273a504becb6e3b33571f92a08
Cr-Commit-Position: refs/heads/master@{#11669}
==========

[commit-bot: I haz the power, 2016-02-18 12:10:09]

Patchset 2 (id:??) landed as
https://crrev.com/5199c74d253bf1273a504becb6e3b33571f92a08
Cr-Commit-Position: refs/heads/master@{#11669}