webrtc/api/androidvideocapturer.h - Issue 1702603002: AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to List/vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/androidvideocapturer.h

Issue 1702603002: AndroidVideoCapturer getSupportedFormats(): Change interface from JSON string to List/vector (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Remove logging from C++. Remove json from api.gyp. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/androidvideocapturer.h

diff --git a/webrtc/api/androidvideocapturer.h b/webrtc/api/androidvideocapturer.h

index a3295e1ff38dbdc1249e1c63f23efa2a96053340..4c73f3159874e76323fdee76a04702c6d575969d 100644

--- a/webrtc/api/androidvideocapturer.h

+++ b/webrtc/api/androidvideocapturer.h

@@ -34,8 +34,7 @@ class AndroidVideoCapturerDelegate : public rtc::RefCountInterface {

// The delegate may not call into AndroidVideoCapturer after this call.

virtual void Stop() = 0;

- // Must returns a JSON string "{{width=xxx, height=xxx, framerate = xxx}}"

- virtual std::string GetSupportedFormats() = 0;

+ virtual std::vector<cricket::VideoFormat> GetSupportedFormats() = 0;

};

// Android implementation of cricket::VideoCapturer for use with WebRtc

« no previous file with comments | « no previous file | webrtc/api/androidvideocapturer.cc » ('j') | no next file with comments »