Move SSLIdentity Generate() implementations from .h to .cc file.

webrtc/base/sslidentity.cc

Index: webrtc/base/sslidentity.cc
diff --git a/webrtc/base/sslidentity.cc b/webrtc/base/sslidentity.cc
index 536e3aa7dc46726273cc16d598296a6ec8172d74..0d7d30e5bd2d139e1bb082f0a3c5ff759f35324e 100644
--- a/webrtc/base/sslidentity.cc
+++ b/webrtc/base/sslidentity.cc
@@ -165,6 +165,18 @@ SSLIdentity* SSLIdentity::Generate(const std::string& common_name,
                                    certificate_lifetime);
 }
 
+SSLIdentity* SSLIdentity::Generate(const std::string& common_name,

[tommi, 2016/02/16 12:00:17]

fyi: typically we tag static methods in the .cc file like so:

// static
void MyClass::Foo() {
}

[torbjorng (webrtc), 2016/02/16 12:22:46]

Done.

+                                   const KeyParams& key_params) {
+  return OpenSSLIdentity::Generate(common_name, key_params,

[tommi, 2016/02/16 12:00:17]

why call into  OpenSSLIdentity here and not the above Generate() function like
before?

[torbjorng (webrtc), 2016/02/16 12:22:46]

Mainly to shorten the call chains, but I think the 3 functions' current
similarity make the code a bit more readable.

+                                   kDefaultCertificateLifetime);
+}
+
+SSLIdentity* SSLIdentity::Generate(const std::string& common_name,
+                                   KeyType key_type) {
+  return OpenSSLIdentity::Generate(common_name, KeyParams(key_type),
+                                   kDefaultCertificateLifetime);
+}

[hbos, 2016/02/16 12:02:18]

Suggestion: These should call the three-paramed SSLIdentity::Generate (which is
what they did before this patch) over OpenSSLIdentity::Generate directly, which
would mean that if we had other implementations than SSL_USE_OPENSSL you would
only have to override the one with three params considering the other ones are
just meant to default the other params. If you do this, move it out of the #if
SSL_USE_OPENSSL clause.

I know you want to get rid of #if SSL_USE_OPENSSL and the extra layer since we
only have one implementation though, but right now this layer exists and the
above suggestion makes sense.

[torbjorng (webrtc), 2016/02/16 12:22:46]

Please see above reply.

+
 SSLIdentity* SSLIdentity::GenerateForTest(const SSLIdentityParams& params) {
   return OpenSSLIdentity::GenerateForTest(params);
 }