Move SSLIdentity Generate() implementations from .h to .cc file.

webrtc/base/sslidentity.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 147 matching lines @@
   return OpenSSLCertificate::FromPEMString(pem_string);
 }
 
 SSLIdentity* SSLIdentity::Generate(const std::string& common_name,
                                    const KeyParams& key_params,
                                    time_t certificate_lifetime) {
   return OpenSSLIdentity::Generate(common_name, key_params,
                                    certificate_lifetime);
 }
 
+SSLIdentity* SSLIdentity::Generate(const std::string& common_name,

[tommi, 2016/02/16 12:00:17]

fyi: typically we tag static methods in the .cc file like so:

// static
void MyClass::Foo() {
}

[torbjorng (webrtc), 2016/02/16 12:22:46]

Done.

+                                   const KeyParams& key_params) {
+  return OpenSSLIdentity::Generate(common_name, key_params,

[tommi, 2016/02/16 12:00:17]

why call into  OpenSSLIdentity here and not the above Generate() function like
before?

[torbjorng (webrtc), 2016/02/16 12:22:46]

Mainly to shorten the call chains, but I think the 3 functions' current
similarity make the code a bit more readable.

+                                   kDefaultCertificateLifetime);
+}
+
+SSLIdentity* SSLIdentity::Generate(const std::string& common_name,
+                                   KeyType key_type) {
+  return OpenSSLIdentity::Generate(common_name, KeyParams(key_type),
+                                   kDefaultCertificateLifetime);
+}

[hbos, 2016/02/16 12:02:18]

Suggestion: These should call the three-paramed SSLIdentity::Generate (which is
what they did before this patch) over OpenSSLIdentity::Generate directly, which
would mean that if we had other implementations than SSL_USE_OPENSSL you would
only have to override the one with three params considering the other ones are
just meant to default the other params. If you do this, move it out of the #if
SSL_USE_OPENSSL clause.

I know you want to get rid of #if SSL_USE_OPENSSL and the extra layer since we
only have one implementation though, but right now this layer exists and the
above suggestion makes sense.

[torbjorng (webrtc), 2016/02/16 12:22:46]

Please see above reply.

+
 SSLIdentity* SSLIdentity::GenerateForTest(const SSLIdentityParams& params) {
   return OpenSSLIdentity::GenerateForTest(params);
 }
 
 SSLIdentity* SSLIdentity::FromPEMStrings(const std::string& private_key,
                                          const std::string& certificate) {
   return OpenSSLIdentity::FromPEMStrings(private_key, certificate);
 }
 
 #else  // !SSL_USE_OPENSSL
@@ skipping 66 matching lines @@
 
   if (bytes_left != 1) {
     // Now just Z should remain.  Its existence was asserted above.
     return -1;
   }
 
   return TmToSeconds(tm);
 }
 
 }  // namespace rtc