Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1701053005: Exclude legacy objc API tests properly. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Exclude legacy objc API tests properly. In https://codereview.webrtc.org/1691463002 the legacy objc tests were moved into a new GYP file, which was conditioned so it's not included for platforms that cannot build it. This condition contained an error which makes the GYP file being processed even if include_tests=0, which causes errors in downstream code. BUG=webrtc:5419 NOTRY=True

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M all.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-17 11:53:45 UTC) #2
henrika_webrtc
LGTM
4 years, 10 months ago (2016-02-17 11:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701053005/1
4 years, 10 months ago (2016-02-17 12:02:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22785c709956365ac51bc3b79135e6debc6418ae Cr-Commit-Position: refs/heads/master@{#11650}
4 years, 10 months ago (2016-02-17 12:03:47 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 12:03:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698