Move talk/session/media -> webrtc/pc

Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/9b8df25c73ac004fba7683b3034cf0b12b0813e3
Cr-Commit-Position: refs/heads/master@{#11592}

[kjellander_webrtc, 2016-02-10 17:20:10]

Description was changed from

==========
Move talk/session/media -> webrtc/pc

libjingle_p2p_unittest will be renamed in a separate follow-up CL.

BUG=webrtc:5419
==========

to

==========
Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a 
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
==========

[kjellander_webrtc, 2016-02-10 17:20:10]

kjellander@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2016-02-10 18:23:31]

Fixed GYP errors

[kjellander_webrtc, 2016-02-10 18:25:46]

Sorry I didn't mean to send this out for review yet (I used -m instead of -t
when uploading).
There's still some work to be done here, but you can surely take a look if you
want.

[pthatcher1, 2016-02-10 19:10:32]

Looking so good already

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/pc/pc_tests.gypi
File webrtc/pc/pc_tests.gypi (right):

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/pc/pc_tests.gypi#n...
webrtc/pc/pc_tests.gypi:13: 'target_name': 'libjingle_p2p_unittest',
rtc_pc_unittest?

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:372: 'target_name': 'libjingle_p2p_unittest_run',
webrtc_pc_unittest_run?

[kjellander_webrtc, 2016-02-10 19:19:20]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 19:19:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691463002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691463002/60001

[kjellander_webrtc, 2016-02-10 19:22:25]

It should be OK to review now (pending no surprise turns up at the trybots that
are now running).

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/pc/pc_tests.gypi
File webrtc/pc/pc_tests.gypi (right):

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/pc/pc_tests.gypi#n...
webrtc/pc/pc_tests.gypi:13: 'target_name': 'libjingle_p2p_unittest',
On 2016/02/10 19:10:32, pthatcher1 wrote:
> rtc_pc_unittest?

Yeah, but in a follow-up CL as I wrote in the CL description. 
I wanted to be able to run the unit test on the trybots in this CL. Then I'll
rename it after landing.

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/webrtc_tests.gypi
File webrtc/webrtc_tests.gypi (right):

https://codereview.webrtc.org/1691463002/diff/60001/webrtc/webrtc_tests.gypi#...
webrtc/webrtc_tests.gypi:372: 'target_name': 'libjingle_p2p_unittest_run',
On 2016/02/10 19:10:32, pthatcher1 wrote:
> webrtc_pc_unittest_run?

It'll be rtc_pc_unittest_run in a follow-up CL after landing this. Now I'm just
moving this block.

[commit-bot: I haz the power, 2016-02-10 19:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 19:24:02]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3356)

[kjellander_webrtc, 2016-02-10 19:36:07]

On 2016/02/10 19:24:02, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   presubmit on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3356)

I'll have a look at the test failures. I suspect I need to set more defines from
https://chromium.googlesource.com/external/webrtc/+/master/talk/build/common.....

[kjellander_webrtc, 2016-02-10 21:22:05]

Patchset #5 (id:80001) has been deleted

[Taylor Brandstetter, 2016-02-10 22:20:47]

https://codereview.webrtc.org/1691463002/diff/100001/all.gyp
File all.gyp (right):

https://codereview.webrtc.org/1691463002/diff/100001/all.gyp#newcode29
all.gyp:29: ['OS=="ios" or (OS=="mac" and target_arch!="ia32") and
include_tests==1', {
Could you explain the purpose of this?

https://codereview.webrtc.org/1691463002/diff/100001/webrtc/api/peerconnectio...
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/1691463002/diff/100001/webrtc/api/peerconnectio...
webrtc/api/peerconnection.cc:18: #include "webrtc/pc/channelmanager.h"
I think you need to run the include sorter; api comes before pc.

[kjellander_webrtc, 2016-02-11 12:59:35]

PTAL
I moved the only target remaining in talk/ (the legacy objc stuff) into
talk/app/webrtc/legacy_objc_api[_tests].gyp instead, to make it more clear why I
had to add that condition in all.gyp.

https://codereview.webrtc.org/1691463002/diff/100001/all.gyp
File all.gyp (right):

https://codereview.webrtc.org/1691463002/diff/100001/all.gyp#newcode29
all.gyp:29: ['OS=="ios" or (OS=="mac" and target_arch!="ia32") and
include_tests==1', {
On 2016/02/10 22:20:47, Taylor Brandstetter wrote:
> Could you explain the purpose of this?

Yeah, it was needed since with this CL there's only one target in
libjingle_tests.gyp. The other platforms gets an error when it's trying to add
dependencies of * targets in the file, but no target is found.

I agree this is a bit ugly and I made it more clear by renaming libjingle.gyp to
talk/app/webrtc/legacy_objc_api.gyp instead (and similar with
libjingle_tests.gyp). 
That should make more sense.

https://codereview.webrtc.org/1691463002/diff/100001/webrtc/api/peerconnectio...
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/1691463002/diff/100001/webrtc/api/peerconnectio...
webrtc/api/peerconnection.cc:18: #include "webrtc/pc/channelmanager.h"
On 2016/02/10 22:20:47, Taylor Brandstetter wrote:
> I think you need to run the include sorter; api comes before pc.

Sure, I planned to just do manual review this time as sorting all headers break
in some places, which I learned in the other CLs). It seems I missed doing that
though :)

https://codereview.webrtc.org/1691463002/diff/120001/talk/app/webrtc/legacy_o...
File talk/app/webrtc/legacy_objc_api.gyp (right):

https://codereview.webrtc.org/1691463002/diff/120001/talk/app/webrtc/legacy_o...
talk/app/webrtc/legacy_objc_api.gyp:1: #
This is a plain rename of libjingle.gyp with what's left in it after this CL.
Just updated paths.

[Taylor Brandstetter, 2016-02-11 17:34:39]

lgtm

[tommi, 2016-02-11 17:46:16]

lgtm

[pthatcher1, 2016-02-11 18:38:56]

lgtm

[kjellander_webrtc, 2016-02-12 05:48:16]

Description was changed from

==========
Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a 
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
==========

to

==========
Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9b8df25c73ac004fba7683b30...
==========

[kjellander_webrtc, 2016-02-12 05:48:18]

Committed patchset #8 (id:160001) manually as
9b8df25c73ac004fba7683b3034cf0b12b0813e3.

[commit-bot: I haz the power, 2016-02-12 05:48:19]

Description was changed from

==========
Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9b8df25c73ac004fba7683b30...
==========

to

==========
Move talk/session/media -> webrtc/pc

The libjingle_p2p target is renamed to rtc_pc.
The libjingle_p2p_unittest test will be renamed in a
separate follow-up CL, to make it possible to run all
trybots successfully for this CL.

BUG=webrtc:5419
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/9b8df25c73ac004fba7683b3034cf0b12b0813e3
Cr-Commit-Position: refs/heads/master@{#11592}
==========

[commit-bot: I haz the power, 2016-02-12 05:48:20]

Patchset 8 (id:??) landed as
https://crrev.com/9b8df25c73ac004fba7683b3034cf0b12b0813e3
Cr-Commit-Position: refs/heads/master@{#11592}