Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1696873002: Adding TSan suppressions temporarily to fix some flaky unit tests. (Closed)

Created:
4 years, 10 months ago by Taylor Brandstetter
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding TSan suppressions temporarily to fix some flaky unit tests. BUG=webrtc:5524 NOTRY=true Committed: https://crrev.com/25d6a0fb69562fb9aa09bbbd06e6e95a6b54348b Cr-Commit-Position: refs/heads/master@{#11643}

Patch Set 1 #

Patch Set 2 : Removing RegisterProtectionCallback suppression since the bug was fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
PTAL. Lately the TSan bot has been failing almost 1/2 times due to these race ...
4 years, 10 months ago (2016-02-12 20:38:49 UTC) #2
pbos-webrtc
On 2016/02/12 20:38:49, Taylor Brandstetter wrote: > PTAL. Lately the TSan bot has been failing ...
4 years, 10 months ago (2016-02-15 11:29:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696873002/20001
4 years, 10 months ago (2016-02-17 00:53:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 00:54:55 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 00:55:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25d6a0fb69562fb9aa09bbbd06e6e95a6b54348b
Cr-Commit-Position: refs/heads/master@{#11643}

Powered by Google App Engine
This is Rietveld 408576698