Fix race on VCM protection callback.

Fix race on VCM protection callback.

Removes protection-callback removal and makes ViEChannel outlive
ViEEncoder to not have races between BitrateAllocator and
VideoSendStream destruction.

BUG=
R=stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/579e832a51e690f7064bb971ca0f22560e179dad

[pbos-webrtc, 2016-02-12 13:09:22]

PTAL, I think some of my refactoring caused this race.
vcm_->RegisterProtectionCallback is not thread-safe and BitrateAllocator is
still running at this point (it gets deregistered when vie_encoder_ goes out of
scope).

[pbos-webrtc, 2016-02-12 13:56:34]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 13:56:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696693002/1

[stefan-webrtc, 2016-02-12 15:29:38]

lgtm

[commit-bot: I haz the power, 2016-02-12 15:30:14]

Description was changed from

==========
Fix race on VCM protection callback.

Removes protection-callback removal and makes ViEChannel outlive
ViEEncoder to not have races between BitrateAllocator and
VideoSendStream destruction.

BUG=
R=stefan@webrtc.org
==========

to

==========
Fix race on VCM protection callback.

Removes protection-callback removal and makes ViEChannel outlive
ViEEncoder to not have races between BitrateAllocator and
VideoSendStream destruction.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/579e832a51e690f7064bb971ca0f22560e179dad
Cr-Commit-Position: refs/heads/master@{#11604}
==========

[commit-bot: I haz the power, 2016-02-12 15:30:15]

Patchset 1 (id:??) landed as
https://crrev.com/579e832a51e690f7064bb971ca0f22560e179dad
Cr-Commit-Position: refs/heads/master@{#11604}

[pbos-webrtc, 2016-02-12 15:30:16]

Description was changed from

==========
Fix race on VCM protection callback.

Removes protection-callback removal and makes ViEChannel outlive
ViEEncoder to not have races between BitrateAllocator and
VideoSendStream destruction.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/579e832a51e690f7064bb971ca0f22560e179dad
Cr-Commit-Position: refs/heads/master@{#11604}
==========

to

==========
Fix race on VCM protection callback.

Removes protection-callback removal and makes ViEChannel outlive
ViEEncoder to not have races between BitrateAllocator and
VideoSendStream destruction.

BUG=
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/579e832a51e690f7064bb971c...
==========

[pbos-webrtc, 2016-02-12 15:30:17]

Committed patchset #1 (id:1) manually as
579e832a51e690f7064bb971ca0f22560e179dad (presubmit successful).