Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: webrtc/api/objc/RTCConfiguration.h

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Changes based on feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCConfiguration.h
diff --git a/webrtc/api/objc/RTCConfiguration.h b/webrtc/api/objc/RTCConfiguration.h
index 144c8d3bd5ebe041b2309809d684e73db7abf5c3..b61a6fc5a27db8fe3a309405387a26b45332c976 100644
--- a/webrtc/api/objc/RTCConfiguration.h
+++ b/webrtc/api/objc/RTCConfiguration.h
@@ -57,20 +57,20 @@ NS_ASSUME_NONNULL_BEGIN
/** Which candidates the ICE agent is allowed to use. The W3C calls it
* |iceTransportPolicy|, while in C++ it is called |type|. */
-@property(nonatomic, assign) RTCIceTransportPolicy iceTransportPolicy;
tkchin_webrtc 2016/02/20 00:17:31 did compiler complain?
hjon_webrtc 2016/02/22 23:03:06 No, was just trying to be consistent as it seemed
tkchin_webrtc 2016/02/23 00:22:26 Where?
hjon_webrtc 2016/02/23 21:06:12 I took another look and we currently have a mix of
tkchin_webrtc 2016/02/24 22:45:12 I'd prefer having the explicit assign.
+@property(nonatomic) RTCIceTransportPolicy iceTransportPolicy;
/** The media-bundling policy to use when gathering ICE candidates. */
-@property(nonatomic, assign) RTCBundlePolicy bundlePolicy;
+@property(nonatomic) RTCBundlePolicy bundlePolicy;
/** The rtcp-mux policy to use when gathering ICE candidates. */
-@property(nonatomic, assign) RTCRtcpMuxPolicy rtcpMuxPolicy;
-@property(nonatomic, assign) RTCTcpCandidatePolicy tcpCandidatePolicy;
-@property(nonatomic, assign) int audioJitterBufferMaxPackets;
-@property(nonatomic, assign) int iceConnectionReceivingTimeout;
-@property(nonatomic, assign) int iceBackupCandidatePairPingInterval;
+@property(nonatomic) RTCRtcpMuxPolicy rtcpMuxPolicy;
+@property(nonatomic) RTCTcpCandidatePolicy tcpCandidatePolicy;
+@property(nonatomic) int audioJitterBufferMaxPackets;
+@property(nonatomic) int iceConnectionReceivingTimeout;
+@property(nonatomic) int iceBackupCandidatePairPingInterval;
/** Key type used to generate SSL identity. Default is ECDSA. */
-@property(nonatomic, assign) RTCEncryptionKeyType keyType;
+@property(nonatomic) RTCEncryptionKeyType keyType;
- (instancetype)init NS_DESIGNATED_INITIALIZER;

Powered by Google App Engine
This is Rietveld 408576698