Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Side by Side Diff: webrtc/api/objc/RTCConfiguration.h

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Changes based on feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 50
51 NS_ASSUME_NONNULL_BEGIN 51 NS_ASSUME_NONNULL_BEGIN
52 52
53 @interface RTCConfiguration : NSObject 53 @interface RTCConfiguration : NSObject
54 54
55 /** An array of Ice Servers available to be used by ICE. */ 55 /** An array of Ice Servers available to be used by ICE. */
56 @property(nonatomic, copy) NSArray<RTCIceServer *> *iceServers; 56 @property(nonatomic, copy) NSArray<RTCIceServer *> *iceServers;
57 57
58 /** Which candidates the ICE agent is allowed to use. The W3C calls it 58 /** Which candidates the ICE agent is allowed to use. The W3C calls it
59 * |iceTransportPolicy|, while in C++ it is called |type|. */ 59 * |iceTransportPolicy|, while in C++ it is called |type|. */
60 @property(nonatomic, assign) RTCIceTransportPolicy iceTransportPolicy; 60 @property(nonatomic) RTCIceTransportPolicy iceTransportPolicy;
tkchin_webrtc 2016/02/20 00:17:31 did compiler complain?
hjon_webrtc 2016/02/22 23:03:06 No, was just trying to be consistent as it seemed
tkchin_webrtc 2016/02/23 00:22:26 Where?
hjon_webrtc 2016/02/23 21:06:12 I took another look and we currently have a mix of
tkchin_webrtc 2016/02/24 22:45:12 I'd prefer having the explicit assign.
61 61
62 /** The media-bundling policy to use when gathering ICE candidates. */ 62 /** The media-bundling policy to use when gathering ICE candidates. */
63 @property(nonatomic, assign) RTCBundlePolicy bundlePolicy; 63 @property(nonatomic) RTCBundlePolicy bundlePolicy;
64 64
65 /** The rtcp-mux policy to use when gathering ICE candidates. */ 65 /** The rtcp-mux policy to use when gathering ICE candidates. */
66 @property(nonatomic, assign) RTCRtcpMuxPolicy rtcpMuxPolicy; 66 @property(nonatomic) RTCRtcpMuxPolicy rtcpMuxPolicy;
67 @property(nonatomic, assign) RTCTcpCandidatePolicy tcpCandidatePolicy; 67 @property(nonatomic) RTCTcpCandidatePolicy tcpCandidatePolicy;
68 @property(nonatomic, assign) int audioJitterBufferMaxPackets; 68 @property(nonatomic) int audioJitterBufferMaxPackets;
69 @property(nonatomic, assign) int iceConnectionReceivingTimeout; 69 @property(nonatomic) int iceConnectionReceivingTimeout;
70 @property(nonatomic, assign) int iceBackupCandidatePairPingInterval; 70 @property(nonatomic) int iceBackupCandidatePairPingInterval;
71 71
72 /** Key type used to generate SSL identity. Default is ECDSA. */ 72 /** Key type used to generate SSL identity. Default is ECDSA. */
73 @property(nonatomic, assign) RTCEncryptionKeyType keyType; 73 @property(nonatomic) RTCEncryptionKeyType keyType;
74 74
75 - (instancetype)init NS_DESIGNATED_INITIALIZER; 75 - (instancetype)init NS_DESIGNATED_INITIALIZER;
76 76
77 @end 77 @end
78 78
79 NS_ASSUME_NONNULL_END 79 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698