Android: Make VideoCapturer an interface for all VideoCapturers to implement

Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to communicate with the Java counterpart. This interface is moved into VideoCapturer. The interface is not touched in this CL, and a follow-up CL is planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in PeerConnectionFactory.createVideoSource() instead of doing it immediately in the ctor.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed: https://crrev.com/5e7834e151c15d9f28a5faa9683a1b5c26bacaef
Cr-Commit-Position: refs/heads/master@{#11606}

[magjed_webrtc, 2016-02-12 10:24:58]

Description was changed from

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
==========

to

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-02-12 10:24:58]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-02-12 12:21:18]

perkj - Please take a look.

[perkj_webrtc, 2016-02-12 12:29:23]

lgtm with the below addressed.

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/androidtests/src/o...
File
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java
(right):

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/androidtests/src/o...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java:225:
capturer.release();
please keep dispose to make this consistent with public classes Tracks,
MediaStreams and PeerConnection.

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/java/src/org/webrt...
File webrtc/api/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/java/src/org/webrt...
webrtc/api/java/src/org/webrtc/VideoCapturer.java:97: void release();
public dispose?

[magjed_webrtc, 2016-02-12 12:42:09]

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/androidtests/src/o...
File
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java
(right):

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/androidtests/src/o...
webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java:225:
capturer.release();
On 2016/02/12 12:29:23, perkj_webrtc wrote:
> please keep dispose to make this consistent with public classes Tracks,
> MediaStreams and PeerConnection.

Done.

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/java/src/org/webrt...
File webrtc/api/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/1696553003/diff/1/webrtc/api/java/src/org/webrt...
webrtc/api/java/src/org/webrtc/VideoCapturer.java:97: void release();
On 2016/02/12 12:29:23, perkj_webrtc wrote:
> public dispose?

Done.

[magjed_webrtc, 2016-02-12 12:42:13]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-02-12 12:42:13]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1696553003/#ps20001 (title:
"Rename release()/isReleased() to dispose()/isDisposed()")

[commit-bot: I haz the power, 2016-02-12 12:42:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696553003/20001

[magjed_webrtc, 2016-02-12 14:06:06]

The CQ bit was unchecked by magjed@webrtc.org

[magjed_webrtc, 2016-02-12 14:31:20]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-02-12 14:31:21]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1696553003/#ps40001 (title:
"Replace 'replace' with 'dispose' in jni as well")

[commit-bot: I haz the power, 2016-02-12 14:32:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696553003/40001

[commit-bot: I haz the power, 2016-02-12 14:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 14:34:39]

Try jobs failed on following builders:
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/12613)

[magjed_webrtc, 2016-02-12 16:05:41]

Description was changed from

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
==========

to

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5e7834e151c15d9f28a5faa96...
==========

[magjed_webrtc, 2016-02-12 16:05:42]

Committed patchset #3 (id:40001) manually as
5e7834e151c15d9f28a5faa9683a1b5c26bacaef (presubmit successful).

[commit-bot: I haz the power, 2016-02-12 16:05:45]

Description was changed from

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/5e7834e151c15d9f28a5faa96...
==========

to

==========
Android: Make VideoCapturer an interface for all VideoCapturers to implement

This CL factors out the interface that AndroidVideoCapturerJni is using to
communicate with the Java counterpart. This interface is moved into
VideoCapturer. The interface is not touched in this CL, and a follow-up CL is
planned to simplify and improve it.

Another change is that the native part of VideoCapturer is created in
PeerConnectionFactory.createVideoSource() instead of doing it immediately in the
ctor.

BUG=webrtc:5519
R=perkj@webrtc.org

Committed: https://crrev.com/5e7834e151c15d9f28a5faa9683a1b5c26bacaef
Cr-Commit-Position: refs/heads/master@{#11606}
==========

[commit-bot: I haz the power, 2016-02-12 16:05:46]

Patchset 3 (id:??) landed as
https://crrev.com/5e7834e151c15d9f28a5faa9683a1b5c26bacaef
Cr-Commit-Position: refs/heads/master@{#11606}