webrtc/api/androidvideocapturer.cc - Issue 1696553003: Android: Make VideoCapturer an interface for all VideoCapturers to implement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/androidvideocapturer.cc

Issue 1696553003: Android: Make VideoCapturer an interface for all VideoCapturers to implement (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Replace 'replace' with 'dispose' in jni as well Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java ('k') | webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/api/androidvideocapturer.cc

diff --git a/webrtc/api/androidvideocapturer.cc b/webrtc/api/androidvideocapturer.cc

index 4311fd7a2ea2fc9e727bf1d02b23d0bf2554d709..cf695c49919117904276bbfcf13d8abe14852865 100644

--- a/webrtc/api/androidvideocapturer.cc

+++ b/webrtc/api/androidvideocapturer.cc

@@ -226,7 +226,7 @@ void AndroidVideoCapturer::OnOutputFormatRequest(

bool AndroidVideoCapturer::GetBestCaptureFormat(

const cricket::VideoFormat& desired,

cricket::VideoFormat* best_format) {

- // Delegate this choice to VideoCapturerAndroid.startCapture().

+ // Delegate this choice to VideoCapturer.startCapture().

*best_format = desired;

return true;

}