Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc

Issue 1696203002: [rtp_rtcp] rtc::scoped_ptr<rtcp::RawPacket> replaced with rtc::Buffer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc
index e52a65159b8eb3e74a706d8b1d4aa22a95b195d8..301e131941dcf67de5d02d828037e3c6923b49ed 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc
@@ -21,7 +21,6 @@
using webrtc::rtcp::Bye;
using webrtc::rtcp::CompoundPacket;
using webrtc::rtcp::Fir;
-using webrtc::rtcp::RawPacket;
using webrtc::rtcp::ReceiverReport;
using webrtc::rtcp::ReportBlock;
using webrtc::rtcp::SenderReport;
@@ -42,9 +41,9 @@ TEST(RtcpCompoundPacketTest, AppendPacket) {
EXPECT_TRUE(rr.WithReportBlock(rb));
rr.Append(&fir);
- rtc::scoped_ptr<RawPacket> packet(rr.Build());
+ rtc::Buffer packet = rr.Build();
RtcpPacketParser parser;
- parser.Parse(packet->Buffer(), packet->Length());
+ parser.Parse(packet.data(), packet.size());
EXPECT_EQ(1, parser.receiver_report()->num_packets());
EXPECT_EQ(kSenderSsrc, parser.receiver_report()->Ssrc());
EXPECT_EQ(1, parser.report_block()->num_packets());
@@ -57,9 +56,9 @@ TEST(RtcpCompoundPacketTest, AppendPacketOnEmpty) {
rr.From(kSenderSsrc);
empty.Append(&rr);
- rtc::scoped_ptr<RawPacket> packet(empty.Build());
+ rtc::Buffer packet = empty.Build();
RtcpPacketParser parser;
- parser.Parse(packet->Buffer(), packet->Length());
+ parser.Parse(packet.data(), packet.size());
EXPECT_EQ(1, parser.receiver_report()->num_packets());
EXPECT_EQ(0, parser.report_block()->num_packets());
}
@@ -78,9 +77,9 @@ TEST(RtcpCompoundPacketTest, AppendPacketWithOwnAppendedPacket) {
sr.Append(&bye);
sr.Append(&rr);
- rtc::scoped_ptr<RawPacket> packet(sr.Build());
+ rtc::Buffer packet = sr.Build();
RtcpPacketParser parser;
- parser.Parse(packet->Buffer(), packet->Length());
+ parser.Parse(packet.data(), packet.size());
EXPECT_EQ(1, parser.sender_report()->num_packets());
EXPECT_EQ(1, parser.receiver_report()->num_packets());
EXPECT_EQ(1, parser.report_block()->num_packets());

Powered by Google App Engine
This is Rietveld 408576698