Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1695763002: Replaced eglbase_jni with with holding a EglBase in PeerConnectionFactory. (Closed)

Created:
4 years, 10 months ago by perkj_webrtc
Modified:
4 years, 10 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replaced eglbase_jni with with holding a EglBase in PeerConnectionFactory. Committed: https://crrev.com/461121c67b4d3625ace6e4fea762c2bef48937a7 Cr-Commit-Position: refs/heads/master@{#11627}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. Removed bad test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -152 lines) Patch
M webrtc/api/api.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/androidmediadecoder_jni.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/androidmediadecoder_jni.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 3 chunks +12 lines, -5 lines 0 comments Download
D webrtc/api/java/jni/eglbase_jni.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/api/java/jni/eglbase_jni.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java View 1 2 chunks +18 lines, -7 lines 0 comments Download
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
perkj_webrtc
Can you please take a look?
4 years, 10 months ago (2016-02-12 16:18:58 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/1695763002/diff/1/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java File webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java (right): https://codereview.webrtc.org/1695763002/diff/1/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java#newcode29 webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java:29: private EglBase localEgl; nit: localEgl -> localEglBase? https://codereview.webrtc.org/1695763002/diff/1/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java#newcode169 ...
4 years, 10 months ago (2016-02-12 18:58:50 UTC) #3
perkj_webrtc
PTAL https://codereview.webrtc.org/1695763002/diff/1/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java File webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java (right): https://codereview.webrtc.org/1695763002/diff/1/webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java#newcode29 webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java:29: private EglBase localEgl; On 2016/02/12 18:58:50, AlexG wrote: ...
4 years, 10 months ago (2016-02-15 13:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695763002/20001
4 years, 10 months ago (2016-02-15 13:23:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 14:28:39 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 14:28:47 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/461121c67b4d3625ace6e4fea762c2bef48937a7
Cr-Commit-Position: refs/heads/master@{#11627}

Powered by Google App Engine
This is Rietveld 408576698