Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: webrtc/api/java/jni/eglbase_jni.h

Issue 1695763002: Replaced eglbase_jni with with holding a EglBase in PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments. Removed bad test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/java/jni/androidmediaencoder_jni.cc ('k') | webrtc/api/java/jni/eglbase_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/jni/eglbase_jni.h
diff --git a/webrtc/api/java/jni/eglbase_jni.h b/webrtc/api/java/jni/eglbase_jni.h
deleted file mode 100644
index 983cc191d01d209f4136653f7e1bf663e68b0dbc..0000000000000000000000000000000000000000
--- a/webrtc/api/java/jni/eglbase_jni.h
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * Copyright 2016 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#ifndef WEBRTC_API_JAVA_JNI_EGLBASE_JNI_H_
-#define WEBRTC_API_JAVA_JNI_EGLBASE_JNI_H_
-
-#include <jni.h>
-
-#include "webrtc/base/constructormagic.h"
-
-namespace webrtc_jni {
-
-// Helper class used for creating a Java instance of org/webrtc/EglBase.
-class EglBase {
- public:
- EglBase();
- ~EglBase();
-
- // Creates an new java EglBase instance. |egl_base_context| must be a valid
- // EglBase$Context.
- // Returns false if |egl_base_context| is a null Java object or if an
- // exception occur in Java.
- bool CreateEglBase(JNIEnv* jni, jobject egl_base_context);
- jobject egl_base_context() const { return egl_base_context_; }
-
- private:
- jobject egl_base_ = nullptr; // instance of org/webrtc/EglBase
- jobject egl_base_context_ = nullptr; // instance of EglBase$Context
-
- RTC_DISALLOW_COPY_AND_ASSIGN(EglBase);
-};
-
-} // namespace webrtc_jni
-
-#endif // WEBRTC_API_JAVA_JNI_EGLBASE_JNI_H_
« no previous file with comments | « webrtc/api/java/jni/androidmediaencoder_jni.cc ('k') | webrtc/api/java/jni/eglbase_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698