Remove GetTransport() from TransportChannelImpl

Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}

Committed: https://crrev.com/b9dd7c5b3a8c63d0036e933f7960a6ab588c8d14
Cr-Commit-Position: refs/heads/master@{#11695}

[mikescarlett, 2016-02-11 02:23:19]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=
==========

[mikescarlett, 2016-02-11 02:23:19]

mikescarlett@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[mikescarlett, 2016-02-13 01:25:39]

I propose nuking GetTransport() from TransportChannelImpl since it's dead code,
and refactoring DtlsTransportChannelWrapper and P2PTransportChannel to not
depend on Transport.

[pthatcher1, 2016-02-17 06:04:28]

lgtm

Thanks for removing dead code.

[mikescarlett, 2016-02-17 21:17:43]

The CQ bit was checked by mikescarlett@webrtc.org

[commit-bot: I haz the power, 2016-02-17 21:17:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691673002/40001

[commit-bot: I haz the power, 2016-02-17 23:20:21]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=
==========

[commit-bot: I haz the power, 2016-02-17 23:20:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 23:20:25]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

[commit-bot: I haz the power, 2016-02-17 23:20:26]

Patchset 3 (id:??) landed as
https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}

[guidou, 2016-02-18 09:57:37]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1709953002/ by guidou@webrtc.org.

The reason for reverting is: This CL is breaking a lot of FYI bots.
The specific change that breaks bots is the removal of a constructor parameter.

See, for example:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build....

[mikescarlett, 2016-02-18 19:02:13]

On 2016/02/18 09:57:37, guidou wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.webrtc.org/1709953002/ by mailto:guidou@webrtc.org.
> 
> The reason for reverting is: This CL is breaking a lot of FYI bots.
> The specific change that breaks bots is the removal of a constructor
parameter.
> 
> See, for example:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build....

Oops. Chromium's remoting/protocol/ice_transport_channel.h apparently uses
P2PTransportChannel.

[mikescarlett, 2016-02-18 19:48:32]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

[mikescarlett, 2016-02-18 20:17:49]

The CQ bit was checked by mikescarlett@webrtc.org

[mikescarlett, 2016-02-18 20:17:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1691673002/#ps60001 (title:
"Restore deleted P2PTransportChannel constructor (and mark deprecated) to not
break Chromium")

[commit-bot: I haz the power, 2016-02-18 20:18:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691673002/60001

[commit-bot: I haz the power, 2016-02-18 20:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 20:25:19]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11038)

[mikescarlett, 2016-02-20 03:05:07]

The CQ bit was checked by mikescarlett@webrtc.org

[commit-bot: I haz the power, 2016-02-20 03:05:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691673002/60001

[commit-bot: I haz the power, 2016-02-20 04:43:48]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

[commit-bot: I haz the power, 2016-02-20 04:43:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-20 04:43:58]

Description was changed from

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}
==========

to

==========
Remove GetTransport() from TransportChannelImpl

This appears to be dead code because GetTransport() is not used by WebRTC. It
also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel.

BUG=

Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a
Cr-Commit-Position: refs/heads/master@{#11662}

Committed: https://crrev.com/b9dd7c5b3a8c63d0036e933f7960a6ab588c8d14
Cr-Commit-Position: refs/heads/master@{#11695}
==========

[commit-bot: I haz the power, 2016-02-20 04:43:59]

Patchset 4 (id:??) landed as
https://crrev.com/b9dd7c5b3a8c63d0036e933f7960a6ab588c8d14
Cr-Commit-Position: refs/heads/master@{#11695}