Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: webrtc/p2p/base/dtlstransportchannel.h

Issue 1691673002: Remove GetTransport() from TransportChannelImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Restore deleted P2PTransportChannel constructor (and mark deprecated) to not break Chromium Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/dtlstransport.h ('k') | webrtc/p2p/base/dtlstransportchannel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/dtlstransportchannel.h
diff --git a/webrtc/p2p/base/dtlstransportchannel.h b/webrtc/p2p/base/dtlstransportchannel.h
index 955b963a3657a1efc7436e4347158b02e7e112e2..f396a57d30ede0a5b9ab4042751459400d7aaa4d 100644
--- a/webrtc/p2p/base/dtlstransportchannel.h
+++ b/webrtc/p2p/base/dtlstransportchannel.h
@@ -82,10 +82,8 @@ class StreamInterfaceChannel : public rtc::StreamInterface {
class DtlsTransportChannelWrapper : public TransportChannelImpl {
public:
// The parameters here are:
- // transport -- the DtlsTransport that created us
// channel -- the TransportChannel we are wrapping
- DtlsTransportChannelWrapper(Transport* transport,
- TransportChannelImpl* channel);
+ explicit DtlsTransportChannelWrapper(TransportChannelImpl* channel);
~DtlsTransportChannelWrapper() override;
void SetIceRole(IceRole role) override { channel_->SetIceRole(role); }
@@ -159,8 +157,6 @@ class DtlsTransportChannelWrapper : public TransportChannelImpl {
}
// TransportChannelImpl calls.
- Transport* GetTransport() override { return transport_; }
-
TransportChannelState GetState() const override {
return channel_->GetState();
}
@@ -218,9 +214,8 @@ class DtlsTransportChannelWrapper : public TransportChannelImpl {
void OnConnectionRemoved(TransportChannelImpl* channel);
void Reconnect();
- Transport* transport_; // The transport_ that created us.
rtc::Thread* worker_thread_; // Everything should occur on this thread.
- // Underlying channel, owned by transport_.
+ // Underlying channel, not owned by this class.
TransportChannelImpl* const channel_;
rtc::scoped_ptr<rtc::SSLStreamAdapter> dtls_; // The DTLS stream
StreamInterfaceChannel* downward_; // Wrapper for channel_, owned by dtls_.
« no previous file with comments | « webrtc/p2p/base/dtlstransport.h ('k') | webrtc/p2p/base/dtlstransportchannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698