Update iOS AppRTCDemo to use the updated Objective-C API.

Update iOS AppRTCDemo to use the updated Objective-C API.

BUG=

Committed: https://crrev.com/79858f8e9a51e1dd17068d674f9008989c085cce
Cr-Commit-Position: refs/heads/master@{#11973}

[hjon_webrtc, 2016-02-12 17:34:56]

hjon@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[hjon_webrtc, 2016-02-12 17:34:56]

This isn't fully done yet, but wanted to raise some questions (noted in
context).

Also, when I uploaded, I got the following error. This seems unrelated to the
changes I made (I think it's related to https://codereview.webrtc.org/1587193006
), so I just bypassed the hooks for now. Would @kjellander be the one to ask
about it?

** Presubmit ERRORS **
Depending on rtc_base is not allowed. Change your dependency to
rtc_base_approved and possibly sanitize and move the desired source file(s) to
rtc_base_approved.
Changed GYP files:
  webrtc/webrtc_examples.gyp

https://codereview.webrtc.org/1690313002/diff/1/webrtc/api/api.gyp
File webrtc/api/api.gyp (right):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/api/api.gyp#newcode245
webrtc/api/api.gyp:245: 'CLANG_ENABLE_OBJC_ARC': 'YES',
Is this how I should ensure ARC is enabled for apprtc_common, apprtc_signaling,
and AppRTCDemo? Or should I enable it for each of those targets individually?
This is how the current libjingle_peerconnection_objc seems to enable it, but at
least personally, enabling per target seems better.

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.h (right):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.h:14: #import
"webrtc/api/objc/RTCVideoTrack.h"
Should all of these paths be absolute? That seemed to be what we did for the
updated API, but I'm not sure if the same style should be used here. From the
current libjingle_peerconnection_objc, it looked like I could also export a
setting for include directories, but I'm not sure which style to use?

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
File webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.m (left):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.m:35: NSArray *uris =
dictionary[kRTCICEServerUrisKey];
Should one IceServer be created with all of these uris or should individual
IceServers be created for each uri?

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
File webrtc/examples/objc/AppRTCDemo/RTCSessionDescription+JSON.m (right):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/RTCSessionDescription+JSON.m:18: + (NSString
*)stringForType:(RTCSdpType)type {
Both this class and ARDSignalingMessage currently translate between the enum and
string version. The conversion in the updated API converts between the enum and
the C++ string. My current thinking is to either put the enum/NSString
conversion in this class and expose it for ARDSignalingMessage or to create a
separate class just for that conversion. Thoughts?

[hjon_webrtc, 2016-02-12 18:26:58]

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.m (left):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:17: #import "RTCFileLogger.h"
I seem to recall that we held off on this because of symbol conflicts, though
it's not noted in https://codereview.webrtc.org/1558453002/. Thoughts on how to
proceed?

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:508: constraints:[self
defaultOfferConstraints]];
Did you have any thoughts on how you wanted to handle these with the blocks API?
Such as everything inline versus having the blocks call out to methods with
common code?

[hjon_webrtc, 2016-02-12 18:50:58]

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
File webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m (right):

https://codereview.webrtc.org/1690313002/diff/1/webrtc/examples/objc/AppRTCDe...
webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m:147:
[_videoCallView.remoteVideoView renderFrame:nil];
Is this line needed? The updated API is currently assuming this is called with a
nonnull value, and I'm not certain if the API or this line needs to be changed.

[hjon_webrtc, 2016-02-19 20:56:21]

Will need both https://codereview.webrtc.org/1692243003/ and
https://codereview.webrtc.org/1696673003/ to land first. Haven't updated Mac
AppRTCDemo yet.

[hjon_webrtc, 2016-02-25 22:40:23]

ptal

[hjon_webrtc, 2016-03-08 16:51:24]

ptal

[tkchin_webrtc, 2016-03-08 19:51:22]

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h:16: #import
"webrtc/api/objc/RTCPeerConnection.h"
move webrtc imports into their own section above

#import "ARDAppClient.h"

#import "webrtc/api/"...

#import "ARD"..

You can probably fwd decl the factory though.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:236: [_turnClient
requestServerWithCompletionHandler:^(RTCIceServer *turnServer,
This should still return an array.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:476:
didCreateSessionDescription:sdp
indent (move this line 5 spaces to the right, and align error: with this line's
:)

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:519:
didCreateSessionDescription:sdp
ditto indent

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:562:
didSetSessionDescriptionWithError:error];
indent

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:687: @"OfferToReceiveAudio" :
@"true",
indent 2 instead of 4:

= @{
  @"Offer..."
};

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:93: RTCSdpType type =
description.type;
now that it's an enum use a switch, and let the bad ones fall through to the
assert

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:93: RTCSdpType type =
description.type;
nit: sdpType

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:152: NSDictionary *values =
statsReport.values;
use an enumerator to iterate over keys + values. Here and elsewhere.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m:26:
didFinishLaunchingWithOptions:(NSDictionary *)base {
?

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m:182: case
RTCIceConnectionStateMax:
nit: any chance we can rename this to RTCIceConnectionStateCount?

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.m:18: #import
"webrtc/base/objc/RTCSSLAdapter.h"

style is
#import "ARDFileHeader.h"  -> File header
-> Blank line
#import <AVFoundation/AVFoundation.h> -> Framework imports
#import "webrtc/base/objc/..." -> thirdparty stuff
-> Blank line
#import "ARDViewController.h" -> Project imports

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m:15: #import
"webrtc/api/objc/RTCNSGLVideoView.h"
ditto move import

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:18: #import
"webrtc/api/objc/RTCMediaConstraints.h"
ditto import order

[hjon_webrtc, 2016-03-10 03:32:43]

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h:16: #import
"webrtc/api/objc/RTCPeerConnection.h"
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> move webrtc imports into their own section above
> 
> #import "ARDAppClient.h"
> 
> #import "webrtc/api/"...
> 
> #import "ARD"..
> 
> You can probably fwd decl the factory though.

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:236: [_turnClient
requestServerWithCompletionHandler:^(RTCIceServer *turnServer,
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> This should still return an array.

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:476:
didCreateSessionDescription:sdp
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> indent (move this line 5 spaces to the right, and align error: with this
line's
> :)

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:519:
didCreateSessionDescription:sdp
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> ditto indent

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:562:
didSetSessionDescriptionWithError:error];
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> indent

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:687: @"OfferToReceiveAudio" :
@"true",
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> indent 2 instead of 4:
> 
> = @{
>   @"Offer..."
> };

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:93: RTCSdpType type =
description.type;
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> now that it's an enum use a switch, and let the bad ones fall through to the
> assert

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:93: RTCSdpType type =
description.type;
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> nit: sdpType

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:152: NSDictionary *values =
statsReport.values;
On 2016/03/08 19:51:21, tkchin_webrtc wrote:
> use an enumerator to iterate over keys + values. Here and elsewhere.

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m:26:
didFinishLaunchingWithOptions:(NSDictionary *)base {
On 2016/03/08 19:51:22, tkchin_webrtc wrote:
> ?

Huh. No idea. I noticed that once when updating against master and thought I had
kept it as |launchOptions|. Guess I goofed that up.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m:182: case
RTCIceConnectionStateMax:
On 2016/03/08 19:51:22, tkchin_webrtc wrote:
> nit: any chance we can rename this to RTCIceConnectionStateCount?

Seems fine to me. Separate CL or as part of this one?

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/mac/APPRTCAppDelegate.m:18: #import
"webrtc/base/objc/RTCSSLAdapter.h"
On 2016/03/08 19:51:22, tkchin_webrtc wrote:
> 
> style is
> #import "ARDFileHeader.h"  -> File header
> -> Blank line
> #import <AVFoundation/AVFoundation.h> -> Framework imports
> #import "webrtc/base/objc/..." -> thirdparty stuff
> -> Blank line
> #import "ARDViewController.h" -> Project imports
> 

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m:15: #import
"webrtc/api/objc/RTCNSGLVideoView.h"
On 2016/03/08 19:51:22, tkchin_webrtc wrote:
> ditto move import

Done.

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/40001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:18: #import
"webrtc/api/objc/RTCMediaConstraints.h"
On 2016/03/08 19:51:22, tkchin_webrtc wrote:
> ditto import order

Done.

https://codereview.webrtc.org/1690313002/diff/140001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ARDCEODTURNClient.m (left):

https://codereview.webrtc.org/1690313002/diff/140001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ARDCEODTURNClient.m:52: if (!turnServers) {
Do we still need this check? Based on changes to -[RTCIceServer
serverFromCEODJSONDictionary:], turnServers will always be a one element array.
Is that correct or should that also change?

https://codereview.webrtc.org/1690313002/diff/140001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/140001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:12: #include
"webrtc/base/ssladapter.h"
Based on the work done in webrtc/api/objc, I believe these should be above the
#imports, correct?

[hjon_webrtc, 2016-03-11 17:14:08]

ptal

[tkchin_webrtc, 2016-03-11 20:47:38]

lgtm

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.m (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:238: NSError *error) {
?

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:99: default:
enumerate other cases (don't use default)

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:14: #import
<Foundation/Foundation.h>
system libraries first (foundation, ocmock)

then webrtc stuff

[hjon_webrtc, 2016-03-11 22:44:15]

ptal

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ARDAppClient.m (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ARDAppClient.m:238: NSError *error) {
On 2016/03/11 20:47:38, tkchin_webrtc wrote:
> ?

Done.

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/ARDSignalingMessage.m:99: default:
On 2016/03/11 20:47:38, tkchin_webrtc wrote:
> enumerate other cases (don't use default)

Done.

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:14: #import
<Foundation/Foundation.h>
On 2016/03/11 20:47:38, tkchin_webrtc wrote:
> system libraries first (foundation, ocmock)
> 
> then webrtc stuff

I also seem to recall #includes before #imports, correct?

[tkchin_webrtc, 2016-03-11 23:33:23]

lgtm

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
File webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm (right):

https://codereview.webrtc.org/1690313002/diff/160001/webrtc/examples/objc/App...
webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm:14: #import
<Foundation/Foundation.h>
On 2016/03/11 22:44:15, hjon_webrtc wrote:
> On 2016/03/11 20:47:38, tkchin_webrtc wrote:
> > system libraries first (foundation, ocmock)
> > 
> > then webrtc stuff
> 
> I also seem to recall #includes before #imports, correct?

yeah. This looks good.

[hjon_webrtc, 2016-03-11 23:59:04]

The CQ bit was checked by hjon@webrtc.org

[commit-bot: I haz the power, 2016-03-11 23:59:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690313002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690313002/180001

[commit-bot: I haz the power, 2016-03-12 00:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 00:25:28]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4091)

[tkchin_webrtc, 2016-03-13 00:47:01]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-13 00:47:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690313002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690313002/180001

[commit-bot: I haz the power, 2016-03-13 01:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-13 01:01:18]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11689)

[hjon_webrtc, 2016-03-14 04:03:49]

The CQ bit was checked by hjon@webrtc.org

[hjon_webrtc, 2016-03-14 04:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1690313002/#ps200001 (title:
"Update against master")

[commit-bot: I haz the power, 2016-03-14 04:03:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690313002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690313002/200001

[commit-bot: I haz the power, 2016-03-14 05:08:30]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-03-14 05:08:39]

Description was changed from

==========
Update iOS AppRTCDemo to use the updated Objective-C API.

BUG=
==========

to

==========
Update iOS AppRTCDemo to use the updated Objective-C API.

BUG=

Committed: https://crrev.com/79858f8e9a51e1dd17068d674f9008989c085cce
Cr-Commit-Position: refs/heads/master@{#11973}
==========

[commit-bot: I haz the power, 2016-03-14 05:08:40]

Patchset 11 (id:??) landed as
https://crrev.com/79858f8e9a51e1dd17068d674f9008989c085cce
Cr-Commit-Position: refs/heads/master@{#11973}