Add support for rtx with h264.

Add support for rtx with h264.

BUG=chromium:500605, webrtc:5516
Committed: https://crrev.com/1e01660899b2fdf45ea3fdaa7adfba85c17e66e9
Cr-Commit-Position: refs/heads/master@{#11570}

[stefan-webrtc, 2016-02-11 08:44:35]

stefan@webrtc.org changed reviewers:
+ pbos@webrtc.org

[stefan-webrtc, 2016-02-11 08:54:22]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 08:54:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689543005/1

[pbos-webrtc, 2016-02-11 09:01:32]

lgtm

https://codereview.webrtc.org/1689543005/diff/1/webrtc/media/base/constants.cc
File webrtc/media/base/constants.cc (right):

https://codereview.webrtc.org/1689543005/diff/1/webrtc/media/base/constants.c...
webrtc/media/base/constants.cc:127: const int kDefaultRtxH264PlType = 99;
This looks safe right now, but can you move constants from:

webrtcvoiceengine.cc:511 const WebRtcVoiceCodecs::CodecPref
WebRtcVoiceCodecs::kCodecPrefs

in this CL or a followup so we don't risk adding overlapping payload types
between audio/video?

[stefan-webrtc, 2016-02-11 09:28:02]

https://codereview.webrtc.org/1689543005/diff/1/webrtc/media/base/constants.cc
File webrtc/media/base/constants.cc (right):

https://codereview.webrtc.org/1689543005/diff/1/webrtc/media/base/constants.c...
webrtc/media/base/constants.cc:127: const int kDefaultRtxH264PlType = 99;
On 2016/02/11 09:01:32, pbos-webrtc wrote:
> This looks safe right now, but can you move constants from:
> 
> webrtcvoiceengine.cc:511 const WebRtcVoiceCodecs::CodecPref
> WebRtcVoiceCodecs::kCodecPrefs
> 
> in this CL or a followup so we don't risk adding overlapping payload types
> between audio/video?

Leaving for follow-up

[commit-bot: I haz the power, 2016-02-11 09:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 09:30:46]

Dry run: Try jobs failed on following builders:
  win_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/8927)

[stefan-webrtc, 2016-02-11 10:42:05]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-02-11 10:42:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689543005/1

[commit-bot: I haz the power, 2016-02-11 10:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689543005/1

[commit-bot: I haz the power, 2016-02-11 12:13:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-11 12:14:07]

Description was changed from

==========
Add support for rtx with h264.

BUG=chromium:500605,webrtc:5516
==========

to

==========
Add support for rtx with h264.

BUG=chromium:500605,webrtc:5516

Committed: https://crrev.com/1e01660899b2fdf45ea3fdaa7adfba85c17e66e9
Cr-Commit-Position: refs/heads/master@{#11570}
==========

[commit-bot: I haz the power, 2016-02-11 12:14:08]

Patchset 1 (id:??) landed as
https://crrev.com/1e01660899b2fdf45ea3fdaa7adfba85c17e66e9
Cr-Commit-Position: refs/heads/master@{#11570}