Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1685083002: Remove java_home GYP variable from webrtc/build/common.gypi (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove java_home GYP variable from webrtc/build/common.gypi The java_home variable is no longer used since https://codereview.webrtc.org/1652123002 so it can be removed. This is also needed to make it possible to roll https://codereview.webrtc.org/1610243002/ into Chromium. TBR=perkj@webrtc.org BUG=webrtc:5418 NOTRY=True Committed: https://crrev.com/c6344aac47c5234adf1ab2676f0184f0468a47b8 Cr-Commit-Position: refs/heads/master@{#11548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/build/common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-10 11:46:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685083002/1
4 years, 10 months ago (2016-02-10 12:26:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 12:27:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 12:27:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6344aac47c5234adf1ab2676f0184f0468a47b8
Cr-Commit-Position: refs/heads/master@{#11548}

Powered by Google App Engine
This is Rietveld 408576698