Remove Java PC support.

Remove Java PC support.
This cl removes none Android Java support.

Committed: https://crrev.com/47b62634441b23d7ccdf4f1e080d8d0fcc099ec0
Cr-Commit-Position: refs/heads/master@{#11522}

[perkj_webrtc, 2016-02-01 16:20:41]

Patchset #1 (id:1) has been deleted

[perkj_webrtc, 2016-02-01 16:22:13]

perkj@webrtc.org changed reviewers:
+ glaznev@webrtc.org, kjellander@webrtc.org, magjed@webrtc.org,
phoglund@webrtc.org

[perkj_webrtc, 2016-02-01 16:22:14]

Please?

[AlexG, 2016-02-01 21:05:33]

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:933: JOW(void,
VideoRenderer_freeGuiVideoRenderer)(JNIEnv*, jclass, jlong j_p) {
Not needed?

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:1869: JOW(jlong,
VideoRenderer_nativeCreateGuiVideoRenderer)(
Not needed as well? I may be wrong, but I think this API was used on Linux only

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java:31: public class
VideoCapturer {
Do we need this class now? If there is no create function() is there sense to
keep dispose()?

[phoglund, 2016-02-02 08:04:43]

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/androidte...
File talk/app/webrtc/androidtests/src/org/webrtc/PeerConnectionTest.java
(right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/PeerConnectionTest.java:557:
VideoCapturerAndroid.create("", null), new MediaConstraints());
You should be able to merge this test with PeerConnectionAndroidTest or whatever
it's called right?

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/README
File talk/app/webrtc/java/README (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/READ...
talk/app/webrtc/java/README:6: in $GYP_DEFINES.
Nit: pull up to previous line (?)

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:1901: // TODO(nisse): This case
is intended to be deleted.
But this deletes the android implementation as well, is that intended?

[kjellander_webrtc, 2016-02-02 08:24:41]

I only reviewed from a GYP/build perspective.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp#newcode80
talk/libjingle.gyp:80: ['OS=="linux"', {
I assume this can be dropped now?

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp#newcode94
talk/libjingle.gyp:94: ['OS=="android"', {
Remove this empty section.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp
File talk/libjingle_tests.gyp (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp#...
talk/libjingle_tests.gyp:269: 'junit_jar':
'<(DEPTH)/third_party/junit-jar/junit-4.11.jar',
Please drop third_party/junit-jar as part of this CL as well.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp#...
talk/libjingle_tests.gyp:299: 'build/build_jar.sh', '<(java_home)',
'<@(_outputs)',
Please drop build/build_jar.sh as part of this CL too.

[magjed_webrtc, 2016-02-02 09:00:01]

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:933: JOW(void,
VideoRenderer_freeGuiVideoRenderer)(JNIEnv*, jclass, jlong j_p) {
On 2016/02/01 21:05:33, AlexG wrote:
> Not needed?

Yes, I think VideoRenderer can be cleaned up as well.

[perkj_webrtc, 2016-02-03 17:00:03]

PTAL

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/androidte...
File talk/app/webrtc/androidtests/src/org/webrtc/PeerConnectionTest.java
(right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/PeerConnectionTest.java:557:
VideoCapturerAndroid.create("", null), new MediaConstraints());
On 2016/02/02 08:04:43, phoglund wrote:
> You should be able to merge this test with PeerConnectionAndroidTest or
whatever
> it's called right?

Done.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/README
File talk/app/webrtc/java/README (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/READ...
talk/app/webrtc/java/README:6: in $GYP_DEFINES.
On 2016/02/02 08:04:43, phoglund wrote:
> Nit: pull up to previous line (?)

Done.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:1901: // TODO(nisse): This case
is intended to be deleted.
On 2016/02/02 08:04:43, phoglund wrote:
> But this deletes the android implementation as well, is that intended?

Yes. it it no longer used.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:933: JOW(void,
VideoRenderer_freeGuiVideoRenderer)(JNIEnv*, jclass, jlong j_p) {
On 2016/02/02 09:00:01, magjed_webrtc wrote:
> On 2016/02/01 21:05:33, AlexG wrote:
> > Not needed?
> 
> Yes, I think VideoRenderer can be cleaned up as well.
Used by VideoRenderer.createGui which is used by PeerConnectionTest. I don't
want to refactor in this cl.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:1869: JOW(jlong,
VideoRenderer_nativeCreateGuiVideoRenderer)(
On 2016/02/01 21:05:33, AlexG wrote:
> Not needed as well? I may be wrong, but I think this API was used on Linux
only

dito- It is still used by PeerConnectionTest.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java:31: public class
VideoCapturer {
On 2016/02/01 21:05:33, AlexG wrote:
> Do we need this class now? If there is no create function() is there sense to
> keep dispose()?

VideoCapturerAndroid inherits from this class. So I did not want to refactor
this in this cl.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp#newcode80
talk/libjingle.gyp:80: ['OS=="linux"', {
On 2016/02/02 08:24:40, kjellander (webrtc) wrote:
> I assume this can be dropped now?

Done.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle.gyp#newcode94
talk/libjingle.gyp:94: ['OS=="android"', {
On 2016/02/02 08:24:40, kjellander (webrtc) wrote:
> Remove this empty section.

Done.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp
File talk/libjingle_tests.gyp (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp#...
talk/libjingle_tests.gyp:269: 'junit_jar':
'<(DEPTH)/third_party/junit-jar/junit-4.11.jar',
On 2016/02/02 08:24:40, kjellander (webrtc) wrote:
> Please drop third_party/junit-jar as part of this CL as well.

Done.

https://codereview.webrtc.org/1652123002/diff/20001/talk/libjingle_tests.gyp#...
talk/libjingle_tests.gyp:299: 'build/build_jar.sh', '<(java_home)',
'<@(_outputs)',
On 2016/02/02 08:24:40, kjellander (webrtc) wrote:
> Please drop build/build_jar.sh as part of this CL too.

Done.

[kjellander_webrtc, 2016-02-03 17:06:29]

LGTM from GYP/build perspective!

[AlexG, 2016-02-04 00:01:22]

lgtm

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:933: JOW(void,
VideoRenderer_freeGuiVideoRenderer)(JNIEnv*, jclass, jlong j_p) {
On 2016/02/03 17:00:03, perkj_webrtc wrote:
> On 2016/02/02 09:00:01, magjed_webrtc wrote:
> > On 2016/02/01 21:05:33, AlexG wrote:
> > > Not needed?
> > 
> > Yes, I think VideoRenderer can be cleaned up as well.
> Used by VideoRenderer.createGui which is used by PeerConnectionTest. I don't
> want to refactor in this cl.

Add TODO item since I think nativeCreateGuiVideoRenderer can not be used on
Android?

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java:31: public class
VideoCapturer {
On 2016/02/03 17:00:03, perkj_webrtc wrote:
> On 2016/02/01 21:05:33, AlexG wrote:
> > Do we need this class now? If there is no create function() is there sense
to
> > keep dispose()?
> 
> VideoCapturerAndroid inherits from this class. So I did not want to refactor
> this in this cl.

Add TODO item?

[magjed_webrtc, 2016-02-04 10:36:48]

lgtm

[phoglund, 2016-02-04 12:22:51]

lgtm

[perkj_webrtc, 2016-02-05 13:43:44]

magjed - ptal- I removed VideoRenderer.creategui... and rebased.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/peerconnection_jni.cc:933: JOW(void,
VideoRenderer_freeGuiVideoRenderer)(JNIEnv*, jclass, jlong j_p) {
On 2016/02/04 00:01:22, AlexG wrote:
> On 2016/02/03 17:00:03, perkj_webrtc wrote:
> > On 2016/02/02 09:00:01, magjed_webrtc wrote:
> > > On 2016/02/01 21:05:33, AlexG wrote:
> > > > Not needed?
> > > 
> > > Yes, I think VideoRenderer can be cleaned up as well.
> > Used by VideoRenderer.createGui which is used by PeerConnectionTest. I don't
> > want to refactor in this cl.
> 
> Add TODO item since I think nativeCreateGuiVideoRenderer can not be used on
> Android?

you are actually right. The test did call this method but there was a condition
that made sure it was not called. So I cleaned this too.

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java (left):

https://codereview.webrtc.org/1652123002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/VideoCapturer.java:31: public class
VideoCapturer {
On 2016/02/04 00:01:22, AlexG wrote:
> On 2016/02/03 17:00:03, perkj_webrtc wrote:
> > On 2016/02/01 21:05:33, AlexG wrote:
> > > Do we need this class now? If there is no create function() is there sense
> to
> > > keep dispose()?
> > 
> > VideoCapturerAndroid inherits from this class. So I did not want to refactor
> > this in this cl.
> 
> Add TODO item?

Done.

[perkj_webrtc, 2016-02-08 08:04:40]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-02-08 08:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
glaznev@webrtc.org, phoglund@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1652123002/#ps100001 (title:
"rebased")

[commit-bot: I haz the power, 2016-02-08 08:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652123002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652123002/100001

[commit-bot: I haz the power, 2016-02-08 09:07:23]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-02-08 09:07:28]

Description was changed from

==========
Remove Java PC support.
This cl removes none Android Java support.
==========

to

==========
Remove Java PC support.
This cl removes none Android Java support.

Committed: https://crrev.com/47b62634441b23d7ccdf4f1e080d8d0fcc099ec0
Cr-Commit-Position: refs/heads/master@{#11522}
==========

[commit-bot: I haz the power, 2016-02-08 09:07:31]

Patchset 5 (id:??) landed as
https://crrev.com/47b62634441b23d7ccdf4f1e080d8d0fcc099ec0
Cr-Commit-Position: refs/heads/master@{#11522}

[phoglund, 2016-02-08 19:43:55]

On 2016/02/08 09:07:31, commit-bot: I haz the power wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/47b62634441b23d7ccdf4f1e080d8d0fcc099ec0
> Cr-Commit-Position: refs/heads/master@{#11522}

The import bot is green and all tests pass, so it looks like this will stick!