Cleanup shared memory handling in DesktopCapturer interface.

Cleanup shared memory handling in DesktopCapturer interface.

Previously shared memory buffers for DesktopCapturer were created
using DesktopCapturer::Callback::CreateSharedBuffer(). That made it
difficult to proxy DesktopCapturer interface from one thread to another.
This CL adds SharedBufferFactory interface that's allowed to be called
on a background thread. This also simplifies clients that don't
need to use shared memory, as they no longer need to override
CreateSharedBuffer().

Committed: https://crrev.com/cc9669c6b80a73bf0481e721841a8cf2f1204a38
Cr-Commit-Position: refs/heads/master@{#11543}

[Sergey Ulanov, 2016-02-08 21:51:52]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2016-02-08 21:51:59]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-02-08 21:53:57]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org

[Sergey Ulanov, 2016-02-08 21:58:35]

This CL is necessary for the other CL you reviewed
https://codereview.chromium.org/1673723002/ . That CL breaks host on Windows
because DesktopCapturerProxy currently doesn't proxy CreateSharedMemory() call
correctly.

[joedow, 2016-02-09 17:21:15]

lgtm

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/desktop_capturer.h (right):

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/desktop_capturer.h:33: // from chromium.
Does this TODO need a bug to track the work?

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc (right):

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc:39: //
SharedMemoryFactory that creates SharedMemory using the deprectead
s/deprectead/deprecated

[Sergey Ulanov, 2016-02-09 20:07:23]

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/desktop_capturer.h (right):

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/desktop_capturer.h:33: // from chromium.
On 2016/02/09 17:21:15, joedow wrote:
> Does this TODO need a bug to track the work?

I don't think it's worth opening bugs for simple cleanups like this one

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc (right):

https://codereview.chromium.org/1678073003/diff/40001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc:39: //
SharedMemoryFactory that creates SharedMemory using the deprectead
On 2016/02/09 17:21:15, joedow wrote:
> s/deprectead/deprecated

Done.

[Sergey Ulanov, 2016-02-09 20:07:29]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-02-09 20:07:30]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1678073003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-09 20:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678073003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678073003/80001

[commit-bot: I haz the power, 2016-02-09 20:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 20:13:43]

Try jobs failed on following builders:
  win_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/12379)

[Sergey Ulanov, 2016-02-09 22:08:43]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-02-09 22:08:44]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1678073003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-09 22:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678073003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678073003/100001

[commit-bot: I haz the power, 2016-02-09 23:13:30]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-02-09 23:13:43]

Description was changed from

==========
Cleanup shared memory handling in DesktopCapturer interface.

Previously shared memory buffers for DesktopCapturer were created
using DesktopCapturer::Callback::CreateSharedBuffer(). That made it
difficult to proxy DesktopCapturer interface from one thread to another.
This CL adds SharedBufferFactory interface that's allowed to be called
on a background thread. This also simplifies clients that don't
need to use shared memory, as they no longer need to override
CreateSharedBuffer().
==========

to

==========
Cleanup shared memory handling in DesktopCapturer interface.

Previously shared memory buffers for DesktopCapturer were created
using DesktopCapturer::Callback::CreateSharedBuffer(). That made it
difficult to proxy DesktopCapturer interface from one thread to another.
This CL adds SharedBufferFactory interface that's allowed to be called
on a background thread. This also simplifies clients that don't
need to use shared memory, as they no longer need to override
CreateSharedBuffer().

Committed: https://crrev.com/cc9669c6b80a73bf0481e721841a8cf2f1204a38
Cr-Commit-Position: refs/heads/master@{#11543}
==========

[commit-bot: I haz the power, 2016-02-09 23:13:43]

Patchset 4 (id:??) landed as
https://crrev.com/cc9669c6b80a73bf0481e721841a8cf2f1204a38
Cr-Commit-Position: refs/heads/master@{#11543}