Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc

Issue 1678073003: Cleanup shared memory handling in DesktopCapturer interface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
diff --git a/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc b/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
index 066943d294af412a43f0e69ce796c9604504ec8e..29f0c744f0905d07c290e18c4dab2be51b864cd1 100644
--- a/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
+++ b/webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc
@@ -81,6 +81,11 @@ void ScreenCapturerWinMagnifier::Start(Callback* callback) {
InitializeMagnifier();
}
+void ScreenCapturerWinMagnifier::SetSharedMemoryFactory(
+ rtc::scoped_ptr<SharedMemoryFactory> shared_memory_factory) {
+ shared_memory_factory_ = std::move(shared_memory_factory);
+}
+
void ScreenCapturerWinMagnifier::Capture(const DesktopRegion& region) {
TickTime capture_start_time = TickTime::Now();
@@ -422,18 +427,12 @@ void ScreenCapturerWinMagnifier::CreateCurrentFrameIfNecessary(
// Note that we can't reallocate other buffers at this point, since the caller
// may still be reading from them.
if (!queue_.current_frame() || !queue_.current_frame()->size().equals(size)) {
- size_t buffer_size =
- size.width() * size.height() * DesktopFrame::kBytesPerPixel;
- SharedMemory* shared_memory = callback_->CreateSharedMemory(buffer_size);
-
- rtc::scoped_ptr<DesktopFrame> buffer;
- if (shared_memory) {
- buffer.reset(new SharedMemoryDesktopFrame(
- size, size.width() * DesktopFrame::kBytesPerPixel, shared_memory));
- } else {
- buffer.reset(new BasicDesktopFrame(size));
- }
- queue_.ReplaceCurrentFrame(buffer.release());
+ rtc::scoped_ptr<DesktopFrame> frame =
+ shared_memory_factory_
+ ? SharedMemoryDesktopFrame::Create(size,
+ shared_memory_factory_.get())
+ : rtc::scoped_ptr<DesktopFrame>(new BasicDesktopFrame(size));
+ queue_.ReplaceCurrentFrame(frame.release());
}
}

Powered by Google App Engine
This is Rietveld 408576698