Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1677543002: Avoid OpenH264 encoder bug for #threads > 1 on Mac and Chromium+Sandbox. (Closed)

Created:
4 years, 10 months ago by hbos
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid OpenH264 encoder bug for #threads > 1 on Mac and Chromium+Sandbox. Until the bug has been further investigated, we're limiting the number of threads to 1 to avoid problems. See crbug.com/583348. BUG=chromium:500605, chromium:468365, chromium:583348 Committed: https://crrev.com/0715a83a07a30fc19603cb25737671235e8fd9c6 Cr-Commit-Position: refs/heads/master@{#11536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hbos
Please take a look, Stefan
4 years, 10 months ago (2016-02-05 16:04:09 UTC) #2
hbos
On 2016/02/05 16:04:09, hbos wrote: > Please take a look, Stefan Bump Stefan
4 years, 10 months ago (2016-02-09 09:19:18 UTC) #3
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-09 09:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677543002/1
4 years, 10 months ago (2016-02-09 09:35:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 10:34:33 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 10:34:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0715a83a07a30fc19603cb25737671235e8fd9c6
Cr-Commit-Position: refs/heads/master@{#11536}

Powered by Google App Engine
This is Rietveld 408576698