Avoid OpenH264 encoder bug for #threads > 1 on Mac and Chromium+Sandbox.

webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
@@ skipping 10 matching lines @@
 #include "webrtc/base/logging.h"
 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
 
 namespace webrtc {
 
 namespace {
 
 const bool kOpenH264EncoderDetailedLogging = false;
 
 int NumberOfThreads(int width, int height, int number_of_cores) {
-  if (width * height >= 1920 * 1080 && number_of_cores > 8) {
-    return 8;  // 8 threads for 1080p on high perf machines.
-  } else if (width * height > 1280 * 960 && number_of_cores >= 6) {
-    return 3;  // 3 threads for 1080p.
-  } else if (width * height > 640 * 480 && number_of_cores >= 3) {
-    return 2;  // 2 threads for qHD/HD.
-  } else {
-    return 1;  // 1 thread for VGA or less.
-  }
+  // TODO(hbos): In Chromium, multiple threads do not work with sandbox on Mac,
+  // see crbug.com/583348. Until further investigated, only use one thread.
+//  if (width * height >= 1920 * 1080 && number_of_cores > 8) {
+//    return 8;  // 8 threads for 1080p on high perf machines.
+//  } else if (width * height > 1280 * 960 && number_of_cores >= 6) {
+//    return 3;  // 3 threads for 1080p.
+//  } else if (width * height > 640 * 480 && number_of_cores >= 3) {
+//    return 2;  // 2 threads for qHD/HD.
+//  } else {
+//    return 1;  // 1 thread for VGA or less.
+//  }
+  return 1;
 }
 
 }  // namespace
 
 static FrameType EVideoFrameType_to_FrameType(EVideoFrameType type) {
   switch (type) {
     case videoFrameTypeInvalid:
       return kEmptyFrame;
     case videoFrameTypeIDR:
       return kVideoFrameKey;
@@ skipping 342 matching lines @@
 }
 
 int32_t H264EncoderImpl::SetPeriodicKeyFrames(bool enable) {
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 void H264EncoderImpl::OnDroppedFrame() {
 }
 
 }  // namespace webrtc