Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: webrtc/modules/audio_coding/acm2/codec_manager.h

Issue 1677013002: Switch to using new ACM methods for encoder management (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@acm-13
Patch Set: DCHECKs Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/rent_a_codec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/acm2/codec_manager.h
diff --git a/webrtc/modules/audio_coding/acm2/codec_manager.h b/webrtc/modules/audio_coding/acm2/codec_manager.h
index fbd3a18b188efa203949159bf0e0b8c9bde353b3..f6c6cd46d2cfa826de65dcedf06a8eebe1f0640e 100644
--- a/webrtc/modules/audio_coding/acm2/codec_manager.h
+++ b/webrtc/modules/audio_coding/acm2/codec_manager.h
@@ -17,6 +17,7 @@
#include "webrtc/base/optional.h"
#include "webrtc/base/thread_checker.h"
#include "webrtc/modules/audio_coding/acm2/rent_a_codec.h"
+#include "webrtc/modules/audio_coding/include/audio_coding_module.h"
#include "webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h"
#include "webrtc/common_types.h"
@@ -55,6 +56,30 @@ class CodecManager final {
bool SetCodecFEC(bool enable_codec_fec);
+ // Uses the provided Rent-A-Codec to create a new encoder stack, if we have a
+ // complete specification; if so, it is then passed to set_encoder. On error,
+ // returns false.
+ bool MakeEncoder(RentACodec* rac, AudioCodingModule* acm) {
+ RTC_DCHECK(rac);
+ RTC_DCHECK(acm);
+ if (!codec_stack_params_.speech_encoder && send_codec_inst_) {
+ // We have no speech encoder, but we have a specification for making one.
+ auto enc = rac->RentEncoder(*send_codec_inst_);
+ if (!enc)
+ return false;
+ codec_stack_params_.speech_encoder = std::move(enc);
+ }
+ auto stack = rac->RentEncoderStack(&codec_stack_params_);
+ if (stack) {
+ // Give new encoder stack to the ACM.
+ acm->SetEncoder(std::move(stack));
+ } else {
+ // The specification was good but incomplete, so we have no encoder stack
+ // to give to the ACM.
+ }
+ return true;
+ }
+
private:
rtc::ThreadChecker thread_checker_;
rtc::Optional<CodecInst> send_codec_inst_;
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/rent_a_codec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698