Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: webrtc/modules/audio_coding/acm2/codec_manager.h

Issue 1677013002: Switch to using new ACM methods for encoder management (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@acm-13
Patch Set: DCHECKs Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/rent_a_codec.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_
12 #define WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_ 12 #define WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_
13 13
14 #include <map> 14 #include <map>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/base/optional.h" 17 #include "webrtc/base/optional.h"
18 #include "webrtc/base/thread_checker.h" 18 #include "webrtc/base/thread_checker.h"
19 #include "webrtc/modules/audio_coding/acm2/rent_a_codec.h" 19 #include "webrtc/modules/audio_coding/acm2/rent_a_codec.h"
20 #include "webrtc/modules/audio_coding/include/audio_coding_module.h"
20 #include "webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h" 21 #include "webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h"
21 #include "webrtc/common_types.h" 22 #include "webrtc/common_types.h"
22 23
23 namespace webrtc { 24 namespace webrtc {
24 25
25 class AudioDecoder; 26 class AudioDecoder;
26 class AudioEncoder; 27 class AudioEncoder;
27 28
28 namespace acm2 { 29 namespace acm2 {
29 30
(...skipping 18 matching lines...) Expand all
48 return &codec_stack_params_; 49 return &codec_stack_params_;
49 } 50 }
50 RentACodec::StackParameters* GetStackParams() { return &codec_stack_params_; } 51 RentACodec::StackParameters* GetStackParams() { return &codec_stack_params_; }
51 52
52 bool SetCopyRed(bool enable); 53 bool SetCopyRed(bool enable);
53 54
54 bool SetVAD(bool enable, ACMVADMode mode); 55 bool SetVAD(bool enable, ACMVADMode mode);
55 56
56 bool SetCodecFEC(bool enable_codec_fec); 57 bool SetCodecFEC(bool enable_codec_fec);
57 58
59 // Uses the provided Rent-A-Codec to create a new encoder stack, if we have a
60 // complete specification; if so, it is then passed to set_encoder. On error,
61 // returns false.
62 bool MakeEncoder(RentACodec* rac, AudioCodingModule* acm) {
63 RTC_DCHECK(rac);
64 RTC_DCHECK(acm);
65 if (!codec_stack_params_.speech_encoder && send_codec_inst_) {
66 // We have no speech encoder, but we have a specification for making one.
67 auto enc = rac->RentEncoder(*send_codec_inst_);
68 if (!enc)
69 return false;
70 codec_stack_params_.speech_encoder = std::move(enc);
71 }
72 auto stack = rac->RentEncoderStack(&codec_stack_params_);
73 if (stack) {
74 // Give new encoder stack to the ACM.
75 acm->SetEncoder(std::move(stack));
76 } else {
77 // The specification was good but incomplete, so we have no encoder stack
78 // to give to the ACM.
79 }
80 return true;
81 }
82
58 private: 83 private:
59 rtc::ThreadChecker thread_checker_; 84 rtc::ThreadChecker thread_checker_;
60 rtc::Optional<CodecInst> send_codec_inst_; 85 rtc::Optional<CodecInst> send_codec_inst_;
61 RentACodec::StackParameters codec_stack_params_; 86 RentACodec::StackParameters codec_stack_params_;
62 87
63 RTC_DISALLOW_COPY_AND_ASSIGN(CodecManager); 88 RTC_DISALLOW_COPY_AND_ASSIGN(CodecManager);
64 }; 89 };
65 90
66 } // namespace acm2 91 } // namespace acm2
67 } // namespace webrtc 92 } // namespace webrtc
68 #endif // WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_ 93 #endif // WEBRTC_MODULES_AUDIO_CODING_ACM2_CODEC_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/rent_a_codec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698