webrtc/call/bitrate_estimator_tests.cc - Issue 1674663002: Initialize VideoSendStream members in constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/bitrate_estimator_tests.cc

Issue 1674663002: Initialize VideoSendStream members in constructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: feedback + test update Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/call/bitrate_estimator_tests.cc

diff --git a/webrtc/call/bitrate_estimator_tests.cc b/webrtc/call/bitrate_estimator_tests.cc

index 50de542a6fae9a144d7dcda8aaef93d79ec1ad09..d8ac9b4ba5265abaf6c28ecd8f2df2ed721eacc5 100644

--- a/webrtc/call/bitrate_estimator_tests.cc

+++ b/webrtc/call/bitrate_estimator_tests.cc

@@ -277,8 +277,8 @@ TEST_F(BitrateEstimatorTest, ImmediatelySwitchToASTForVideo) {

RtpExtension(RtpExtension::kAbsSendTime, kASTExtensionId));

receiver_log_.PushExpectedLogLine(kSingleStreamLog);

- receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);

+ receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

streams_.push_back(new Stream(this, false));

EXPECT_TRUE(receiver_log_.Wait());

}

@@ -293,8 +293,8 @@ TEST_F(BitrateEstimatorTest, SwitchesToASTForVideo) {

video_send_config_.rtp.extensions[0] =

RtpExtension(RtpExtension::kAbsSendTime, kASTExtensionId);

- receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);

+ receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

streams_.push_back(new Stream(this, false));

EXPECT_TRUE(receiver_log_.Wait());

}

@@ -309,16 +309,16 @@ TEST_F(BitrateEstimatorTest, SwitchesToASTThenBackToTOFForVideo) {

video_send_config_.rtp.extensions[0] =

RtpExtension(RtpExtension::kAbsSendTime, kASTExtensionId);

- receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);

+ receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");

streams_.push_back(new Stream(this, false));

EXPECT_TRUE(receiver_log_.Wait());

video_send_config_.rtp.extensions[0] =

RtpExtension(RtpExtension::kTOffset, kTOFExtensionId);

+ receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);

receiver_log_.PushExpectedLogLine(

"WrappingBitrateEstimator: Switching to transmission time offset RBE.");

- receiver_log_.PushExpectedLogLine(kSingleStreamLog);

streams_.push_back(new Stream(this, false));

streams_[0]->StopSending();

streams_[1]->StopSending();

« no previous file with comments | « no previous file | webrtc/video/video_send_stream.h » ('j') | webrtc/video/vie_receiver.cc » ('J')