Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1669993003: Remove deprecated PeerConnectionObserver::OnStateChange and OnIceComplete (Closed)

Created:
4 years, 10 months ago by perkj_webrtc
Modified:
4 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated PeerConnectionObserver::OnStateChange and OnIceComplete These methods are no longer used. OnStateChange needs to be removed from Chrome before this cl lands. https://codereview.chromium.org/1668413003/ TBR=glaznev@webrtc.org for webrtc/examples Committed: https://crrev.com/dfb769d848e08ad4b15e94da502bbc2d99072d1d Cr-Commit-Position: refs/heads/master@{#11537}

Patch Set 1 : Fixed client #

Patch Set 2 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -77 lines) Patch
M talk/app/webrtc/peerconnection.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 2 chunks +3 lines, -11 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 2 chunks +10 lines, -20 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 chunks +7 lines, -24 lines 0 comments Download
M webrtc/examples/peerconnection/client/conductor.h View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
perkj_webrtc
please - small cleanup.
4 years, 10 months ago (2016-02-05 11:39:34 UTC) #5
pthatcher1
lgtm
4 years, 10 months ago (2016-02-05 16:54:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669993003/60001
4 years, 10 months ago (2016-02-08 13:24:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3298)
4 years, 10 months ago (2016-02-08 13:29:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669993003/60001
4 years, 10 months ago (2016-02-09 10:38:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 10 months ago (2016-02-09 11:09:47 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 11:09:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfb769d848e08ad4b15e94da502bbc2d99072d1d
Cr-Commit-Position: refs/heads/master@{#11537}

Powered by Google App Engine
This is Rietveld 408576698