Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1669993003: Remove deprecated PeerConnectionObserver::OnStateChange and OnIceComplete (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index 9c0cefaca63df61fdefa48fcf06b7d2821f87cf5..940f0fb9e6f8940ada3cdaf1d6e51f2bae054287 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -465,11 +465,7 @@ class PeerConnectionObserver {
// Triggered when the SignalingState changed.
virtual void OnSignalingChange(
- PeerConnectionInterface::SignalingState new_state) {}
-
- // Triggered when SignalingState or IceState have changed.
- // TODO(bemasc): Remove once callers transition to OnSignalingChange.
- virtual void OnStateChange(StateType state_changed) {}
+ PeerConnectionInterface::SignalingState new_state) = 0;
// Triggered when media is received on a new stream from remote peer.
virtual void OnAddStream(MediaStreamInterface* stream) = 0;
@@ -485,19 +481,15 @@ class PeerConnectionObserver {
// Called any time the IceConnectionState changes
virtual void OnIceConnectionChange(
- PeerConnectionInterface::IceConnectionState new_state) {}
+ PeerConnectionInterface::IceConnectionState new_state) = 0;
// Called any time the IceGatheringState changes
virtual void OnIceGatheringChange(
- PeerConnectionInterface::IceGatheringState new_state) {}
+ PeerConnectionInterface::IceGatheringState new_state) = 0;
// New Ice candidate have been found.
virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
- // TODO(bemasc): Remove this once callers transition to OnIceGatheringChange.
- // All Ice candidates have been found.
- virtual void OnIceComplete() {}
-
// Called when the ICE connection receiving status changes.
virtual void OnIceConnectionReceivingChange(bool receiving) {}
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698