Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1665173002: Experimental patch for adapting adaptation to CPU count on Mac. (Closed)

Created:
4 years, 10 months ago by torbjorng (webrtc)
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Experimental patch for adapting adaptation to CPU count on Mac. BUG= Committed: https://crrev.com/448468d575725f67de4eedb3519b46e2a2e9374f Cr-Commit-Position: refs/heads/master@{#11553}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix typo in comment #

Patch Set 3 : Address feedback from tommi #

Total comments: 13

Patch Set 4 : Rewrite changes #

Patch Set 5 : Move include to .cc file #

Total comments: 4

Patch Set 6 : Address feedback #

Patch Set 7 : Rewrite again. Use 1/4 of a physical core as goal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M webrtc/video/overuse_frame_detector.h View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 2 3 4 5 6 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (8 generated)
tommi
Thanks for uploading Torbjorn. This looks very interesting to me, so much actually that I ...
4 years, 10 months ago (2016-02-04 16:40:02 UTC) #2
torbjorng (webrtc)
Thanks, issues addressed. https://codereview.webrtc.org/1665173002/diff/1/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): https://codereview.webrtc.org/1665173002/diff/1/webrtc/video/overuse_frame_detector.h#newcode45 webrtc/video/overuse_frame_detector.h:45: : low_encode_usage_threshold_percent(42), On 2016/02/04 16:40:02, tommi-webrtc ...
4 years, 10 months ago (2016-02-04 16:54:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665173002/40001
4 years, 10 months ago (2016-02-04 19:33:08 UTC) #5
tommi
more nits :) I ran the cq dryrun just in case https://codereview.webrtc.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): ...
4 years, 10 months ago (2016-02-04 20:32:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 21:17:55 UTC) #8
Robert Sesek
https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h#newcode59 webrtc/video/overuse_frame_detector.h:59: host_info(mach_host_self(), HOST_BASIC_INFO, (host_info_t)&hbi, &datasize); The result of mach_host_self must ...
4 years, 10 months ago (2016-02-04 22:37:15 UTC) #10
tommi (sloooow) - chröme
https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h#newcode59 webrtc/video/overuse_frame_detector.h:59: host_info(mach_host_self(), HOST_BASIC_INFO, (host_info_t)&hbi, &datasize); On 2016/02/04 22:37:15, Robert Sesek ...
4 years, 10 months ago (2016-02-04 22:44:41 UTC) #12
mflodman
Adding Åsa to the loop, since she has spent many hours looking at this.
4 years, 10 months ago (2016-02-05 06:56:03 UTC) #14
torbjorng (webrtc)
This is less experimental and leaks less resources than the original CL. I moved the ...
4 years, 10 months ago (2016-02-05 16:31:06 UTC) #15
tommi
lg - I think we should get Asa's feedback on this. https://codereview.webrtc.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): ...
4 years, 10 months ago (2016-02-05 22:56:36 UTC) #16
Robert Sesek
https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h File webrtc/video/overuse_frame_detector.h (right): https://codereview.chromium.org/1665173002/diff/40001/webrtc/video/overuse_frame_detector.h#newcode59 webrtc/video/overuse_frame_detector.h:59: host_info(mach_host_self(), HOST_BASIC_INFO, (host_info_t)&hbi, &datasize); On 2016/02/05 16:31:05, torbjorng (webrtc) ...
4 years, 10 months ago (2016-02-05 22:59:58 UTC) #17
torbjorng (webrtc)
Thanks for feedback! I will wait for Asa's feedback. And I also would like to ...
4 years, 10 months ago (2016-02-06 14:02:26 UTC) #18
åsapersson
The modification of the thresholds lgtm.
4 years, 10 months ago (2016-02-08 09:09:14 UTC) #19
tommi
lgtm
4 years, 10 months ago (2016-02-08 09:57:10 UTC) #20
tommi
On 2016/02/08 09:57:10, tommi-webrtc wrote: > lgtm Torbjorn - are we waiting for approval or ...
4 years, 10 months ago (2016-02-09 09:46:02 UTC) #21
torbjorng (webrtc)
I have looked more into the CPU usage distribution. The overuse mechanism that this CL ...
4 years, 10 months ago (2016-02-09 13:32:13 UTC) #22
torbjorng (webrtc)
PTAL asapersson and tommi.
4 years, 10 months ago (2016-02-10 14:29:01 UTC) #23
tommi
lgtm
4 years, 10 months ago (2016-02-10 14:48:45 UTC) #24
åsapersson
lgtm
4 years, 10 months ago (2016-02-10 15:03:22 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665173002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665173002/120001
4 years, 10 months ago (2016-02-10 15:11:14 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-10 16:12:02 UTC) #28
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:12:11 UTC) #30
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/448468d575725f67de4eedb3519b46e2a2e9374f
Cr-Commit-Position: refs/heads/master@{#11553}

Powered by Google App Engine
This is Rietveld 408576698