talk/app/webrtc/videosourceinterface.h - Issue 1660103003: Delete FrameInput method and FrameInputWrapper class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/videosourceinterface.h

Issue 1660103003: Delete FrameInput method and FrameInputWrapper class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comment improvement. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/videosourceinterface.h

diff --git a/talk/app/webrtc/videosourceinterface.h b/talk/app/webrtc/videosourceinterface.h

index 7ce0de8b7125a2d44a13884288def86efb2ca3ac..8b0176534e6d0cbb9223b213b8a7e5aad4c1e67a 100644

--- a/talk/app/webrtc/videosourceinterface.h

+++ b/talk/app/webrtc/videosourceinterface.h

@@ -55,7 +55,9 @@ class VideoSourceInterface : public MediaSourceInterface {

virtual void RemoveSink(

rtc::VideoSinkInterface<cricket::VideoFrame>* output) = 0;

virtual const cricket::VideoOptions* options() const = 0;

- virtual cricket::VideoRenderer* FrameInput() = 0;

+ // TODO(nisse): Dummy implementation. Delete as soon as chrome's

+ // MockVideoSource is updated.

+ virtual cricket::VideoRenderer* FrameInput() { return nullptr; }

protected:

virtual ~VideoSourceInterface() {}

« no previous file with comments | « talk/app/webrtc/videosource_unittest.cc ('k') | talk/app/webrtc/videosourceproxy.h » ('j') | no next file with comments »