Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: talk/app/webrtc/videosourceinterface.h

Issue 1660103003: Delete FrameInput method and FrameInputWrapper class. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comment improvement. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/videosource_unittest.cc ('k') | talk/app/webrtc/videosourceproxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // Stop the video capturer. 48 // Stop the video capturer.
49 virtual void Stop() = 0; 49 virtual void Stop() = 0;
50 virtual void Restart() = 0; 50 virtual void Restart() = 0;
51 51
52 // Adds |output| to the source to receive frames. 52 // Adds |output| to the source to receive frames.
53 virtual void AddSink( 53 virtual void AddSink(
54 rtc::VideoSinkInterface<cricket::VideoFrame>* output) = 0; 54 rtc::VideoSinkInterface<cricket::VideoFrame>* output) = 0;
55 virtual void RemoveSink( 55 virtual void RemoveSink(
56 rtc::VideoSinkInterface<cricket::VideoFrame>* output) = 0; 56 rtc::VideoSinkInterface<cricket::VideoFrame>* output) = 0;
57 virtual const cricket::VideoOptions* options() const = 0; 57 virtual const cricket::VideoOptions* options() const = 0;
58 virtual cricket::VideoRenderer* FrameInput() = 0; 58 // TODO(nisse): Dummy implementation. Delete as soon as chrome's
59 // MockVideoSource is updated.
60 virtual cricket::VideoRenderer* FrameInput() { return nullptr; }
59 61
60 protected: 62 protected:
61 virtual ~VideoSourceInterface() {} 63 virtual ~VideoSourceInterface() {}
62 }; 64 };
63 65
64 } // namespace webrtc 66 } // namespace webrtc
65 67
66 #endif // TALK_APP_WEBRTC_VIDEOSOURCEINTERFACE_H_ 68 #endif // TALK_APP_WEBRTC_VIDEOSOURCEINTERFACE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/videosource_unittest.cc ('k') | talk/app/webrtc/videosourceproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698