Make cricket::VideoCapturer implement VideoSourceInterface

talk/media/webrtc/webrtcvideoengine2.cc

Index: talk/media/webrtc/webrtcvideoengine2.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc
index 2d5ec5383b3f30ff6ae6e2bb7c9b8ddfd655b102..b0b392391237a07867fca3edeee137589fecf5af 100644
--- a/talk/media/webrtc/webrtcvideoengine2.cc
+++ b/talk/media/webrtc/webrtcvideoengine2.cc
@@ -1016,6 +1016,15 @@ bool WebRtcVideoChannel2::SetVideoSend(uint32_t ssrc, bool enable,
   return true;
 }
 
+rtc::VideoSinkInterface<cricket::VideoFrame>* WebRtcVideoChannel2::GetSink(
+    uint32_t ssrc) {
+  rtc::CritScope stream_lock(&stream_crit_);
+  if (send_streams_.find(ssrc) == send_streams_.end()) {
+    return NULL;
+  }
+  return send_streams_[ssrc];
+}
+
 bool WebRtcVideoChannel2::ValidateSendSsrcAvailability(
     const StreamParams& sp) const {
   for (uint32_t ssrc: sp.ssrcs) {
@@ -1623,12 +1632,11 @@ static void CreateBlackFrame(webrtc::VideoFrame* video_frame,
          video_frame->allocated_size(webrtc::kVPlane));
 }
 
-void WebRtcVideoChannel2::WebRtcVideoSendStream::InputFrame(
-    VideoCapturer* capturer,
-    const VideoFrame* frame) {
-  TRACE_EVENT0("webrtc", "WebRtcVideoSendStream::InputFrame");
-  webrtc::VideoFrame video_frame(frame->GetVideoFrameBuffer(), 0, 0,
-                                 frame->GetVideoRotation());
+void WebRtcVideoChannel2::WebRtcVideoSendStream::OnFrame(
+    const cricket::VideoFrame& frame) {
+  TRACE_EVENT0("webrtc", "WebRtcVideoSendStream::OnFrame");
+  webrtc::VideoFrame video_frame(frame.GetVideoFrameBuffer(), 0, 0,
+                                 frame.GetVideoRotation());
   rtc::CritScope cs(&lock_);
   if (stream_ == NULL) {
     // Frame input before send codecs are configured, dropping frame.
@@ -1645,15 +1653,9 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::InputFrame(
     LOG(LS_VERBOSE) << "VideoFormat 0x0 set, Dropping frame.";
     return;
   }
-  if (muted_) {
-    // Create a black frame to transmit instead.
-    CreateBlackFrame(&video_frame,
-                     static_cast<int>(frame->GetWidth()),
-                     static_cast<int>(frame->GetHeight()));
-  }

[pthatcher, 2016/02/01 18:40:54]

It can't be muted any more?

[perkj_webrtc, 2016/02/02 16:24:00]

Muted as was moved to the track enabled/disabled by niels. muted_ was/ is
controlled by setting the track to disabled... So this will create a black frame
out of a black frame....

Anyway lets keep this for the moment and focus on the source/sink refactoring in
this cl. 

 
-  int64_t frame_delta_ms = frame->GetTimeStamp() / rtc::kNumNanosecsPerMillisec;
-  // frame->GetTimeStamp() is essentially a delta, align to webrtc time
+  int64_t frame_delta_ms = frame.GetTimeStamp() / rtc::kNumNanosecsPerMillisec;
+  // frame.GetTimeStamp() is essentially a delta, align to webrtc time
   if (first_frame_timestamp_ms_ == 0) {
     first_frame_timestamp_ms_ = rtc::Time() - frame_delta_ms;
   }
@@ -1662,7 +1664,7 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::InputFrame(
   video_frame.set_render_time_ms(last_frame_timestamp_ms_);
   // Reconfigure codec if necessary.
   SetDimensions(
-      video_frame.width(), video_frame.height(), capturer->IsScreencast());
+      video_frame.width(), video_frame.height(), is_screencast_);
 
   stream_->Input()->IncomingCapturedFrame(video_frame);
 }
@@ -1705,10 +1707,8 @@ bool WebRtcVideoChannel2::WebRtcVideoSendStream::SetCapturer(
     }
 
     capturer_ = capturer;
+    is_screencast_ = capturer_ ? capturer_->IsScreencast() : false;
   }
-  // Lock cannot be held while connecting the capturer to prevent lock-order
-  // violations.
-  capturer->SignalVideoFrame.connect(this, &WebRtcVideoSendStream::InputFrame);
   return true;
 }
 
@@ -1756,7 +1756,6 @@ bool WebRtcVideoChannel2::WebRtcVideoSendStream::DisconnectCapturer() {
     capturer = capturer_;
     capturer_ = NULL;
   }
-  capturer->SignalVideoFrame.disconnect(this);
   return true;
 }