Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: talk/app/webrtc/remotevideocapturer_unittest.cc

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments. Removed AddSink Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/remotevideocapturer_unittest.cc
diff --git a/talk/app/webrtc/remotevideocapturer_unittest.cc b/talk/app/webrtc/remotevideocapturer_unittest.cc
index 8e79325bff71039ce59a0ed57575334abec474bc..78dbbbbff5877e91555cba9b4f53261a2f2eff98 100644
--- a/talk/app/webrtc/remotevideocapturer_unittest.cc
+++ b/talk/app/webrtc/remotevideocapturer_unittest.cc
@@ -51,13 +51,10 @@ class RemoteVideoCapturerTest : public testing::Test,
virtual void SetUp() {
capturer_.SignalStateChange.connect(
this, &RemoteVideoCapturerTest::OnStateChange);
- capturer_.SignalVideoFrame.connect(
- this, &RemoteVideoCapturerTest::OnVideoFrame);
}
~RemoteVideoCapturerTest() {
capturer_.SignalStateChange.disconnect(this);
- capturer_.SignalVideoFrame.disconnect(this);
}
int captured_frame_num() const {
@@ -77,11 +74,6 @@ class RemoteVideoCapturerTest : public testing::Test,
capture_state_ = capture_state;
}
- void OnVideoFrame(VideoCapturer* capturer, const VideoFrame* frame) {
- EXPECT_EQ(&capturer_, capturer);
- ++captured_frame_num_;
- }
-
int captured_frame_num_;
CaptureState capture_state_;
};
@@ -120,13 +112,3 @@ TEST_F(RemoteVideoCapturerTest, GetBestCaptureFormat) {
EXPECT_TRUE(capturer_.GetBestCaptureFormat(desired, &best_format));
EXPECT_EQ(expected_format, best_format);
}
-
-TEST_F(RemoteVideoCapturerTest, InputFrame) {
- EXPECT_EQ(0, captured_frame_num());
-
- cricket::WebRtcVideoFrame test_frame;
- capturer_.SignalVideoFrame(&capturer_, &test_frame);
- EXPECT_EQ(1, captured_frame_num());
- capturer_.SignalVideoFrame(&capturer_, &test_frame);
- EXPECT_EQ(2, captured_frame_num());
-}

Powered by Google App Engine
This is Rietveld 408576698