talk/app/webrtc/androidvideocapturer.cc - Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/androidvideocapturer.cc

Issue 1655793003: Make cricket::VideoCapturer implement VideoSourceInterface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed comments. Removed AddSink Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/androidvideocapturer.cc

diff --git a/talk/app/webrtc/androidvideocapturer.cc b/talk/app/webrtc/androidvideocapturer.cc

index 6b0d51c5cca2b489162204cc70a3879688ef2223..418292d2c1d0aed85160769ecee9ea28022e656b 100644

--- a/talk/app/webrtc/androidvideocapturer.cc

+++ b/talk/app/webrtc/androidvideocapturer.cc

@@ -43,7 +43,8 @@ namespace webrtc {

// for ref counted I420 frames instead of this hack.

class AndroidVideoCapturer::FrameFactory : public cricket::VideoFrameFactory {

public:

- FrameFactory(const rtc::scoped_refptr<AndroidVideoCapturerDelegate>& delegate)

+ explicit FrameFactory(

+ const rtc::scoped_refptr<AndroidVideoCapturerDelegate>& delegate)

: delegate_(delegate) {

// Create a CapturedFrame that only contains header information, not the

// actual pixel data.

@@ -157,8 +158,6 @@ AndroidVideoCapturer::AndroidVideoCapturer(

formats.push_back(format);

}

SetSupportedFormats(formats);

- // Do not apply frame rotation by default.

- SetApplyRotation(false);

}

AndroidVideoCapturer::~AndroidVideoCapturer() {

« no previous file with comments | « no previous file | talk/app/webrtc/remotevideocapturer_unittest.cc » ('j') | webrtc/media/base/videobroadcaster.h » ('J')